-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EuiEmptyPrompt] Removed min-height
for vertical layouts
#5763
[EuiEmptyPrompt] Removed min-height
for vertical layouts
#5763
Conversation
Preview documentation changes for this PR: https://eui.elastic.co/pr_5763/ |
Preview documentation changes for this PR: https://eui.elastic.co/pr_5763/ |
min-height
for vertical layouts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Fixed! Thank you.
Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
Preview documentation changes for this PR: https://eui.elastic.co/pr_5763/ |
Preview documentation changes for this PR: https://eui.elastic.co/pr_5763/ |
Summary
Fixes #5755.
This PR fixes a bug in
EuiEmptyPrompt
where amin-height
was unnecessary being applied for vertical layouts.Checklist
[ ] Checked in mobile[ ] Props have proper autodocs and playground toggles[ ] Added documentation[ ] Checked Code Sandbox works for any docs examples[ ] Added or updated jest and cypress tests[ ] Checked for breaking changes and labeled appropriately[ ] Checked for accessibility including keyboard-only and screenreader modes[ ] Updated the Figma library counterpart