-
Notifications
You must be signed in to change notification settings - Fork 841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
May 2022 deprecations #5868
May 2022 deprecations #5868
Conversation
Hey @constancecchen Can we also remove the following deprecations (we never added to the issue but are sooo old now)? Just the ones I have expanded in this screenshot: |
Ah I totally forgot to search for that, thanks Caroline! Yes, I'll make that part of this PR |
Preview documentation changes for this PR: https://eui.elastic.co/pr_5868/ |
- use `theme.partition` instead
- use separate `data-gridcell-column-id` & `data-gridcell-row-index` attributes instead
…assed to `EuiMarkdownEditor`
A few quick requests from respective codeowners for a few reviews/QA, and some notes of Kibana conversions that will need to be made:
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5868/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked over items 4-11. LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are no current usages of popoverPosition in Kibana main
🎉
EuiCharts - 0b09e59 - @thompsongl
Not really sure how to evaluate this one in Kibana, I assume no changes needed
Correct
EuiSuggestItem - b6c7e2a
@thompsongl can you confirm that lines 137-139 were handled correctly? I was unsure whether or not to remove line 138 entirely
Looks right to me!
Preview documentation changes for this PR: https://eui.elastic.co/pr_5868/ |
Hmmm, looks like a flaky EuiDataGrid spec. linking for future reference/flake tracking: https://kibana-ci.elastic.co/job/elastic+eui+pull-request-test/7021/console jenkins test this |
Preview documentation changes for this PR: https://eui.elastic.co/pr_5868/ |
Going to go ahead and merge since the remaining EuiMarkdownEditor deprecation doesn't affect Kibana. @chandlerprall if you see any issues with d61acf4 let me know and I can open up a follow-up PR. |
…iDatePicket component with new / valid values. A list of values were deprecated and new values were added in EUI PR #5868 (elastic/eui#5868)
…condensed as it is no longer a part of the Amsterdam theme via EUI PR #5868(elastic/eui#5868)
…condensed as it is no longer a part of the Amsterdam theme via EUI PR #5868(elastic/eui#5868)
* Initial commit for EUI 57.0.0 upgrade * Handle i18n changes * Resolved type errors in DatePicker and Markdown Editor * Resolve test failures in Jest Test Suite #1. Updated multiple snapshots for euiLink and euiTitle as they have been converted to Emotion * Resolved failing tests for Jest Suite #2. Updated snapshots for euiHealth, euiAvatar, euiSpacer, euiTitle, and euiLink as they have recently been converted to Emotion * Resolved failing tests for Jest Suite 3. Updated failing snapshots as EuiSpacer, EuiText, EuiCallout, EuiHorizontalRule, EuiTitle, and EuiLink have been converted to Emotion. Updated the i18n translation snapshots * Upgrade EUI verion to 58.0.0 * Resolved tests failures from Jest Test Suite 4. Updated snapshots as EuiLink, EuiTitle, EuiHorizontalRule, EuiSpace, and EuiCallout have been converted to Emotion * Resolved failing test cases for Jest Test Suite 5. Updated snapshots as EuiLoader has been converted to Emotion * Resolved failing tests in Jest Test Suite 6. Updated snapshots as EuiSpacer, EuiHorizontalRule, Eui Callout, and EuiLink have been converted to Emotion * Resolved type errors for EuiDatePicker component * Resolved type error within EuiContextMenu by removing the watchedItemProps prop. It was recently deprecated in EUI PR# 5880 (elastic/eui#5880) as is no longer needed * Resolved type error within EuiContextMenu by removing the watchedItemProps prop. It was recently deprecated in EUI PR# 5880 (elastic/eui#5880) as is no longer needed * Resolved type error within EuiContextMenu by removing the watchedItemProps prop. It was recently deprecated in EUI PR# 5880 (elastic/eui#5880) as is no longer needed * Resolved type errors by updating the popoverPlacement prop for the EuiDatePicket component with new / valid values. A list of values were deprecated and new values were added in EUI PR #5868 (elastic/eui#5868) * Resolved type error within EuiTabs by removing instances of display: condensed as it is no longer a part of the Amsterdam theme via EUI PR #5868(elastic/eui#5868) * Remove deprecated `display` prop from EuiTabs * Deprecate `.eui-textOverflowWrap` * Deprecate EuiSuggestItem `labelDisplay` prop * [EuiStepsHorizontal] Replace deprecated `isComplete`/`isSelected` with `status` * Update last EuiStepsHorizontal `status` migration - this one was more complex than the previous commit due to existing `status` usage and conditional steps. Some amount of logic was simplified via `completedStep` * Resolved type error within EuiTabs by removing instances of display: condensed as it is no longer a part of the Amsterdam theme via EUI PR #5868(elastic/eui#5868) * Resolved failing test cases in Jest Test Suite 5. Updated snapshots as EuiTitle has been converted to Emotion * Resovlved failing test cases in Jest Test Suite 4. Updated snapshots as EuiTitle and EuiSpacer have been converted to Emotion. Resolved failing tests for EuiLink click simlulations by esuring the test is referencing the correct element. * Resolved failing test cases in Jest Test Suite 3. Updated snapshots as EuiLink, EuiSpacr, and EuiTItle have been converted to Emotion. Updated various test cases to ensure that the references to EuiLink are correct * [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix' * Resolved failing test cases in Jest Test Suite 1. Updated snapshots as EUI text utilities have been converted to Emotion. Updated referenes to EuiLink to ensure test are simulating clicks on the correct elements * Resolved failing test for Jet Test Suite 2. Updated required snapshots. Updated references to EuiLink to ensure that tests are simulating clicks on the correct elements * [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix' * Resolved failing test cases for Jest Test Suite 5. Updated references to EuiLink to ensure tests are targeting the correct element * [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix' * Resolved failing test cases across the Jest Test Suites. Updated required snaphots for components recently converted to Emotion. Updated test cases to ensure that tests targeting EuiLink are using the correct element. * Resolved failing tests from multiple Jest test suites. Updated snapshots for components that have recently been converted to Emotion. Updated tests that reference the EuiLink component to ensure the correct element is being targeted * Updated the getEuiStepsHorizontal function. Previously, this function used the .euiStepHorizontal-isSelected class (now deprecated) to determine which step was current. The function has been updated to use the status prop. * Updated Jest integration test snapshots to account for the recent conversion of EuiLoader to Emotion * Resolved failing tests in Jest suites 2 and 4. Updated required snapshots and references for tests using EuiLink * Removed a console statement. Extracted a nested turnary operation into its own function. * Rollback new turnary function and replace it with a simple if/else * Rollback new turnary function and replace it with a simple if/else * Rollback new turnary function and replace it with a simple if/else * Rollback new turnary function and replace it with a simple if/else * [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix' * Resolved failing test cases in Jest Suites 3 and 5 by updating required snapshots * revert doc_viewer_source test and snapshot changes * Take care of merge conflict in license_checker: * Reverted .render() change for analytics_no_data_page.component.test.tsx. Restored snapshot * Reverted .render() change for analytics_no_data_page.component.test.tsx. Restored snapshot Co-authored-by: Constance Chen <constance.chen@elastic.co> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Greg Thompson <thompson.glowe@gmail.com>
Summary
Per #1469:
popoverPosition
options from EuiDatePicker ([EuiDatePicker]react-datepicker
tosrc/
; use EUI services #5339 (review))PartitionConfig
from Charts theme Update elastic-charts to v41.0.1 #5492data-gridcell-id
attribute from EuiDataGridCell #5515Extra deprecations found throughout the repo:
noDivider
prop fromEuiFilterButton
- usewithNext
prop insteadisSelected
andisComplete
props fromEuiHorizontalStep
- usestatus
prop insteadisHollow
prop fromEuiStep
- this visual appearance is no longer used in Amsterdamdisplay
prop fromEuiTabs
&EuiTabbedContent
- this visual appearance is no longer used in AmsterdamdescriptionDisplay
andlabelDisplay
props fromEuiSuggestItem
- usetruncate
andlabelWidth
instead, respectively.euiButton---subdued
className and$euiButtonTypes.subdued
Sass variable - usetext
color instead.eui-textOverflowWrap
- use.eui-textBreakWord
instead.euiYScrollWithShadows
- use.eui-yScrollWithShadows
insteadEuiMarkdownEditor
no longer automatically includes the tooltip plugin in custom plugin arrays passed touiPlugins
. To use EUI's tooltip plugin, usegetDefaultEuiMarkdownPlugins()
Checklist