-
Notifications
You must be signed in to change notification settings - Fork 840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EuiIcon] Update user Icon #5877
Conversation
Preview documentation changes for this PR: https://eui.elastic.co/pr_5877/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @opauloh,
Thanks for opening this PR. This new user icon works for your use case when the icon is in line with text, this way it doesn't draw too much attention.
But the old IMO works better for other use cases like avatars.
So I would propose to also maintain the old icon and rename it to userAvatar
.
@codearos @Max-Iskra can you add the new icon to our Figma library??
Hi @miukimiu, Thanks for reviewing my PR and letting me know about other scenarios, I'll update it to keep the old user icon as |
@miukimiu - Just updated the PR with the cc @codearos / @Max-Iskra |
Preview documentation changes for this PR: https://eui.elastic.co/pr_5877/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @opauloh. LGTM! 🎉
Teste in Chrome, Safari, Edge, and Firefox.
@opauloh @miukimiu Yup, will add new icom to Figma library. |
Summary
This PR introduces a new style for the
user
Icon, that change was proposed by the AWP Design Team to make it more consistent in the library. In most of the cases, we're using outline icons.Also, as suggested by @miukimiu, we are keeping the current
user
Icon renamed asuserAvatar
icon, to cover other use cases in which the currentuser
Icon works better.cc @codearos @Max-Iskra
Screenshots
Grid
Use cases
Session Viewer UI
Avatars
userAvatar
icon), works betterChecklist