[EuiPageTemplates] Some fixes for BWC #6015
Conversation
- Added `height` as optional prop to all `euiYScroll` mixins
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6015/ |
…page_next/fix_deprecated
- Adds `mainProps` to EuiPageTemplate for allowing customization of things like `id` (for skip link) - Fixed docs site 404 illustrations - Removed old `euiBreakpoint` for new one - Fixed Screen reader live docs’ usage of EuiPageTemplate
|
Ok, this PR is ready for review. Once merged into the Feature branch, I'll do one final pass through the entire checklist including the final CL items and Kibana local test. |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6015/ |
There was a problem hiding this comment.
I looked at the code and tested it locally in Chrome, Safari, and Firefox.
There's a local warning that must be resolved:
Warning: React does not recognize the `innerProps` prop on a DOM element.I also added some suggestions and all the rest looks good to me. 🎉
| @@ -0,0 +1,30 @@ | |||
| import React, { useState } from 'react'; | |||
|
|
|||
| import { EuiPageTemplate_Deprecated as EuiPageTemplate } from '../../../../src'; | |||
There was a problem hiding this comment.
It looks like the GREP mechanism for the imports of the source code doesn't understand this as syntax and is adding commas between:
Anyone know of a quick fix?
There was a problem hiding this comment.
My attempt to fix this. Replace the following code:
With:
const combinedImports = elasticImports.includes('as')
? elasticImports.join(' ')
: elasticImports.join(',\n ');But better @thompsongl comes with a better solution. 🤣
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6015/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6015/ |
EuiPageTemplate
mainPropsto support customidand other basic HTML attributes to be passed to the inner /<main>content wrapperEuiPageSection
EuiPageTemplate.Sidebar
EuiPageTemplate.BottomBar
paddingSizefrom being passed through since this affects all 4 sides and un-aligns the contents to the page contents. If consumers want to adjust, they can pass their ownstyleoverrides.cssblock and addedoverflow: hiddenin case the contents contains negative margins (like flex groups) that are larger than the padding area.EuiPageTemplate__Deprecated
paddingSize.Other
heightas an option to theeuiYScroll()mixins to easily change from100%to something else.euiBreakpointEmotion mixinChecklist
[ ] Checked in Chrome, Safari, Edge, and Firefox[ ] Checked Code Sandbox works for any docs examples[ ] Checked for breaking changes and labeled appropriately[ ] Updated the Figma library counterpart[ ] A changelog entry exists and is marked appropriately