Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing duplicate Form mixins #609

Merged
merged 4 commits into from
Apr 2, 2018
Merged

Fixing duplicate Form mixins #609

merged 4 commits into from
Apr 2, 2018

Conversation

cchaos
Copy link
Contributor

@cchaos cchaos commented Mar 30, 2018

  • Moved form variables and mixins to their own file
  • Removed extraneous global_styling/mixins/forms file and importing the correct files in the filter_group and combo_box files.

@cchaos cchaos requested a review from snide March 30, 2018 21:51
snide
snide approved these changes Mar 30, 2018
View reviewed changes
Copy link
Contributor

@snide snide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. TY.

@cchaos cchaos merged commit 71f6efa into elastic:master Apr 2, 2018
@cchaos cchaos deleted the form_mixins branch April 2, 2018 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snide snide snide approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cchaos @snide