Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiCard] Various fixes & cleanup from Emotion conversion #6341

Merged
merged 7 commits into from
Nov 3, 2022
Merged

[EuiCard] Various fixes & cleanup from Emotion conversion #6341

merged 7 commits into from
Nov 3, 2022

Commits on Nov 3, 2022

  1. [REVERT ME] Repro/testing

    @cee-chen
    cee-chen committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    0ab504b View commit details
    Browse the repository at this point in the history

  2. Example of failing cloned CSS 

    - note missing euiAvatar classes in `emotion-euiCard__icon`
    @cee-chen
    cee-chen committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    2aba077 View commit details
    Browse the repository at this point in the history

  3. Fix EuiCard icons not correctly merging css

    @cee-chen
    cee-chen committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    267d6d4 View commit details
    Browse the repository at this point in the history

  4. Fix EuiCheckableCard not sending top level css prop to the same D… 

    …OM node as its `className` prop
    @cee-chen
    cee-chen committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    7cf8c57 View commit details
    Browse the repository at this point in the history

  5. [opinionated] Remove unused euiCard modifier classNames 

    no results in Kibana for `euiCard-` whatsoever, so feels safe to remove

+ clean up types

+ add unit tests for each text alignment
    @cee-chen
    cee-chen committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    1c3a421 View commit details
    Browse the repository at this point in the history

  6. changelog

    @cee-chen
    cee-chen committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    c4463ab View commit details
    Browse the repository at this point in the history

  7. Revert "[REVERT ME] Repro/testing" 

    This reverts commit 0ab504b.
    @cee-chen
    cee-chen committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    487506c View commit details
    Browse the repository at this point in the history