Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiTab] Fix standalone tabs not defaulting to a size #6366

Merged
merged 2 commits into from
Nov 15, 2022
Merged

[EuiTab] Fix standalone tabs not defaulting to a size #6366

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f7f74b0
[EuiTab] Fix standalone tabs not defaulting to a size
cee-chen Nov 15, 2022
ff3db8c
changelog
cee-chen Nov 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/components/tabs/__snapshots__/tab.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ exports[`EuiTab props append is rendered 1`] = `
Append
</span>
<span
class="euiTab__content emotion-euiTab__content"
class="euiTab__content emotion-euiTab__content-m"
>
children
</span>
Expand All @@ -29,7 +29,7 @@ exports[`EuiTab props disabled and selected 1`] = `
type="button"
>
<span
class="euiTab__content emotion-euiTab__content-selected-disabled"
class="euiTab__content emotion-euiTab__content-m-selected-disabled"
>
Click Me
</span>
Expand All @@ -45,7 +45,7 @@ exports[`EuiTab props disabled is rendered 1`] = `
type="button"
>
<span
class="euiTab__content emotion-euiTab__content-disabled"
class="euiTab__content emotion-euiTab__content-m-disabled"
>
Click Me
</span>
Expand All @@ -63,7 +63,7 @@ exports[`EuiTab props href renders anchor 1`] = `
role="tab"
>
<span
class="euiTab__content emotion-euiTab__content"
class="euiTab__content emotion-euiTab__content-m"
>
children
</span>
Expand All @@ -78,7 +78,7 @@ exports[`EuiTab props isSelected is rendered 1`] = `
type="button"
>
<span
class="euiTab__content emotion-euiTab__content-selected"
class="euiTab__content emotion-euiTab__content-m-selected"
>
children
</span>
Expand All @@ -95,7 +95,7 @@ exports[`EuiTab props onClick renders button 1`] = `
type="button"
>
<span
class="euiTab__content emotion-euiTab__content"
class="euiTab__content emotion-euiTab__content-m"
>
children
</span>
Expand All @@ -115,7 +115,7 @@ exports[`EuiTab props prepend is rendered 1`] = `
Prepend
</span>
<span
class="euiTab__content emotion-euiTab__content"
class="euiTab__content emotion-euiTab__content-m"
>
children
</span>
Expand Down
2 changes: 1 addition & 1 deletion src/components/tabs/tab.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ export const EuiTab: FunctionComponent<Props> = ({
rel,
prepend,
append,
size,
size = 'm',
expand,
...rest
}) => {
Expand Down
3 changes: 3 additions & 0 deletions upcoming_changelogs/6366.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
**Bug fixes**

- Fixed `EuiTab` not defaulting to size `m`