Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty prompt and content updates #6425

Merged
merged 3 commits into from
Nov 23, 2022
Merged

Empty prompt and content updates #6425

merged 3 commits into from
Nov 23, 2022

Conversation

boriskirov
Copy link
Contributor

@boriskirov boriskirov commented Nov 22, 2022 •
edited
Loading

Summary

In this 145598, I identified that we have two things missing in the documentation for our Empty prompts:

  • the messages are different in the documentation, compared to the one used in Cloud (based on this 94718) @florent-leborgne, please if you could have a look, if needed I can provide more context
  • The Access denied prompt is different in our EUI documentation compared to the one proposed, so I updated those to be available

image

image

General checklist

  • Checked in both light and dark modes
  • Checked in mobile
  • Checked in Chrome, Safari, Edge, and Firefox
  • Props have proper autodocs and playground toggles
  • Added documentation
  • Checked Code Sandbox works for any docs examples
  • Added or updated jest and cypress tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • Updated the Figma library counterpart
  • A changelog entry exists and is marked appropriately

@boriskirov boriskirov added skip-changelog documentation Issues or PRs that only affect documentation - will not need changelog entries labels Nov 22, 2022
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_6425/

@boriskirov boriskirov marked this pull request as ready for review November 22, 2022 15:14
@elizabetdev
Copy link
Contributor

Just to give more context to @florent-leborgne, the texts currently on the empty prompt page were suggested by @gchaps.

But in Cloud, the texts seem a little bit different. So we want the texts to align.

Also in Kibana (elastic/kibana#145598) the text follows what we currently have in EUI. But @boriskirov is updating the texts to match the ones in Cloud: https://github.com/elastic/cloud/pull/94718.

To be consistent in Cloud and Kibana, what should be the right texts?

elizabetdev
elizabetdev approved these changes Nov 22, 2022
View reviewed changes
Copy link
Contributor

@elizabetdev elizabetdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @boriskirov.

Tested in Chrome, Safari, Edge, and Firefox. I also looked at the code and LGTM! 🎉

Let's just wait for @florent-leborgne or @gchaps approvals. 👍🏽

florent-leborgne
florent-leborgne approved these changes Nov 22, 2022
View reviewed changes
Copy link
Contributor

@florent-leborgne florent-leborgne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, Gail and I took a quick look and left a minor suggestion. Thanks for pinging us :)

src-docs/src/views/empty_prompt/prompt_types/page_not_found.tsx Outdated Show resolved Hide resolved
@boriskirov @florent-leborgne
Update src-docs/src/views/empty_prompt/prompt_types/page_not_found.tsx
e3cd90a 
Co-authored-by: florent-leborgne <florent.leborgne@elastic.co>
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_6425/

@elizabetdev
Copy link
Contributor

jenkins test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_6425/

@boriskirov boriskirov merged commit 3f7bd87 into elastic:main Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florent-leborgne florent-leborgne florent-leborgne approved these changes

@elizabetdev elizabetdev elizabetdev approved these changes

Assignees
No one assigned
Labels
documentation Issues or PRs that only affect documentation - will not need changelog entries skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@boriskirov @kibanamachine @elizabetdev @florent-leborgne