Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<EuiText> support for pre, pre code, code #654

Merged
merged 3 commits into from
Apr 11, 2018

Conversation

bevacqua
Copy link
Contributor

So that we can mostly render basic Markdown using <EuiText> as-is, per Slack conversation with @snide

screen shot 2018-04-10 at 22 40 39

@bevacqua bevacqua requested a review from snide April 11, 2018 01:42
@@ -154,6 +154,30 @@
text-transform: uppercase;
}

pre {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are mostly copied over from _code_block.scss, we might prefer a mixin? Not sure.

@bevacqua bevacqua requested a review from cjcenizal April 11, 2018 13:20
Copy link
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Could you please add examples of pre, pre code, and code to the EuiText documentation page before merging? Don't forget to update the CHANGELOG too.

@bevacqua bevacqua merged commit d9cdcd8 into elastic:master Apr 11, 2018
@bevacqua bevacqua deleted the text-enhancement-for-code branch April 11, 2018 14:29
@bevacqua
Copy link
Contributor Author

screen shot 2018-04-11 at 11 27 36

Now live in production

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants