Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Step status props #673

Merged
merged 3 commits into from
Apr 16, 2018
Merged

Step status props #673

merged 3 commits into from
Apr 16, 2018

Conversation

snide
Copy link
Contributor

@snide snide commented Apr 13, 2018

Closes #667

Adds a status prop from EuiSteps and EuiStep. This allows it to have some different styling for last item checks. Pretty sure this styling originally came from @formgeist so I kept it as is and just added a bit of animation.

@nreese if you're in a hurry with this, we can merge it, but expect @cchaos to possibly tweak the styling later.

@snide snide requested review from nreese and cchaos April 13, 2018 23:04
Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Thanks for adding this feature

@nreese
Copy link
Contributor

nreese commented Apr 14, 2018

@snide I am in no rush to merge. Lets make sure @cchaos has a chance to chime in with input.

Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We should probably also add EuiStep to the props component list in the first example.

}

&.euiStep__circle--complete {
animation: euiGrow $euiAnimSpeedFast ease-in;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How would the bounce easing matrix look?

@snide
Copy link
Contributor Author

snide commented Apr 16, 2018

@cchaos done for both. merging.

@snide snide merged commit 89b676c into elastic:master Apr 16, 2018
@snide snide deleted the steps/check branch April 16, 2018 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants