Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiFocusTrap] Workaround for scrollLock prop causing nested portals/popovers to be unscrollable #6744

Merged
merged 4 commits into from
Apr 28, 2023
Merged

[EuiFocusTrap] Workaround for scrollLock prop causing nested portals/popovers to be unscrollable #6744

merged 4 commits into from
Apr 28, 2023

Commits on Apr 28, 2023

  1. Fix scrollLock causing nested popovers to be unable to scroll in Ki… 

    …bana

- using a workaround recommended by `react-focus-on`'s author
    @cee-chen
    cee-chen committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    4412a1f View commit details
    Browse the repository at this point in the history

  2. Write Cypress e2e tests for scrollLock behavior 

    - to confirm that things are working as expected and try to prevent future regressions
    @cee-chen
    cee-chen committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    4942bdf View commit details
    Browse the repository at this point in the history

  3. Add support for gapMode 

    - Kibana ignores `margin`, so we default to `padding` instead
    @cee-chen
    cee-chen committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    e51cc67 View commit details
    Browse the repository at this point in the history

  4. changelog

    @cee-chen
    cee-chen committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    4efed01 View commit details
    Browse the repository at this point in the history