Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timelineWithArrow glyph #6822

Merged
merged 3 commits into from
Jun 1, 2023
Merged

Add timelineWithArrow glyph #6822

merged 3 commits into from
Jun 1, 2023

Conversation

ryankeairns
Copy link
Contributor

@ryankeairns ryankeairns commented May 31, 2023

Related to #6731

Summary

Add timelineWithArrow glyph to EuiIcon

Figma

Screen Shot 2023-05-31 at 11 56 16 AM Screen Shot 2023-05-31 at 11 57 36 AM

Docs

Screen Shot 2023-05-31 at 11 56 39 AM Screen Shot 2023-05-31 at 11 56 29 AM

QA

General checklist

  • Checked in both light and dark modes
    - [ ] Checked in mobile
    - [ ] Checked in Chrome, Safari, Edge, and Firefox
    - [ ] Props have proper autodocs (using @default if default values are missing) and playground toggles
  • Added documentation
    - [ ] Checked Code Sandbox works for any docs examples
    - [ ] Added or updated jest and cypress tests
    - [ ] Checked for breaking changes and labeled appropriately
    - [ ] Checked for accessibility including keyboard-only and screenreader modes
  • Updated the Figma library counterpart
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_6822/

@ryankeairns ryankeairns marked this pull request as ready for review May 31, 2023 21:59
@ryankeairns ryankeairns mentioned this pull request May 31, 2023
11 tasks
@cee-chen cee-chen enabled auto-merge (squash) June 1, 2023 15:37
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_6822/

@cee-chen cee-chen merged commit 8ad5493 into main Jun 1, 2023
cee-chen added a commit to elastic/kibana that referenced this pull request Jun 6, 2023
## Summary

`eui@81.2.0` ⏩ `eui@81.3.0`

✨ Highlights:

- fixes #158644
- Adds a new Timeline icon for use within `EuiMarkdownEditor` (cc
@kqualters-elastic)
- Expandable rows used within `EuiBasicTable` and `EuiInMemoryTable` now
have a faster and snappier expand animation

___

## [`81.3.0`](https://github.com/elastic/eui/tree/v81.3.0)

- Added `timelineWithArrow` glyph to `EuiIcon`
([#6822](elastic/eui#6822))

**Bug fixes**

- Fixed `EuiCodeBlock` potentially incorrectly ignoring lines ending
with a question mark when using the Copy button.
([#6794](elastic/eui#6794))
- Fixed `EuiCodeBlock` to not include line numbers when copying content
([#6824](elastic/eui#6824))
- Fixed the expanded row animation on `EuiBasicTable` causing
cross-browser Safari issues
([#6826](elastic/eui#6826))
@cee-chen cee-chen deleted the rk/add-timelineWithArrow branch June 6, 2023 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants