-
Notifications
You must be signed in to change notification settings - Fork 843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Text styles #683
Text styles #683
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making these changes! I'm especially stoked to see EuiTextAlign
finally making it in.
When you update CHANGELOG.md, could you please move the 0.0.40 entry about EuiText
under "Breaking changes"? And then could you add a note to that bullet about how it's undone by this change, similar to the style of the deprecation notice in 0.0.19? This way anybody reading the change log will come across that bullet and feel comfy skipping on ahead to this release without worrying about the breaking change.
<p>You can also pass alignment to <EuiCode>EuiText</EuiCode> directly with a prop</p> | ||
</EuiText> | ||
<EuiText textAlign="center" color="secondary"> | ||
<p>And in conjuction with coloring.</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small typo: "conjunction"
src/components/text/_text.scss
Outdated
@@ -98,13 +110,16 @@ | |||
list-style: decimal; | |||
} | |||
|
|||
dt { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add this to the EuiText
example?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
- Styled `dl` inside EuiText - Set a min-width of 75% when grow is false - Moved toComponent button into GuidePage (docs)
Fixes browser defaults overriding font families for input, textarea, select, button
- Added EuiTextAlign - Implementing in the same way as EuiTextColor
- Added <dl> to example - fixed typo
@cjcenizal I'm confused by your comment about the changelog. I see the bullet: - Tweaked sizing, weights, color, line-heights, and
added more levels to `EuiTitle` and `EuiText`
([#627](https://github.com/elastic/eui/pull/627)) under 0.0.40 but I don't know how this is a breaking change and nor is it completely undone in this PR. The only thing this PR changes from that is making the - Added `grow` prop to `EuiText` ([#662](https://github.com/elastic/eui/pull/662)) |
@cchaos I would consider the original change to apply **Breaking changes**
- **Note: This breaking change is reversed in 0.0.43.** Added a default `max-width` to `EuiText`. ([#627](https://github.com/elastic/eui/pull/627)) My addition of the - Removed the default `max-width` from `EuiText`. This can still be applied by setting `grow={false}`. ([#683](https://github.com/elastic/eui/pull/683)) |
That works thank you. |
Change some default text styles
EuiText grow=true
as default (fixes Unify max-width rules for titles, text, and form rows #669)dl
's inside EuiTextmakeHighContrastColor
function.Added to the reset file
There was an issue where input, textarea, select, and buttons were getting the user agent font family instead of inheriting from
html
. Adding them to the reset file fixes browser defaults from overriding font families.Before
After
Added support for text alignment (fixes #647)
Docs