Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Emotion] Convert EuiButtonEmpty #6863

Merged
merged 15 commits into from
Jun 27, 2023
Merged

[Emotion] Convert EuiButtonEmpty #6863

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
46a2251
[EuiButtonEmpty] Convert to use new non-deprecated internal content c…
cee-chen Jun 15, 2023
920804d
[EuiButtonEmpty] Convert child wrapper CSS to Emotion
cee-chen Jun 15, 2023
710565e
[EuiButtonEmpty] Convert styles shared with `EuiButtonDisplay`
cee-chen Jun 15, 2023
430eb86
[EuiButtonEmpty] Convert remaining CSS specific to empty buttons
cee-chen Jun 15, 2023
1698c7a
[EuiButtonEmpty] Remove modifier classes
cee-chen Jun 15, 2023
77b7172
[EuiButtonEmpty] Delete Sass files
cee-chen Jun 15, 2023
865fb7b
Delete `EuiButtonContentDeprecated` and all button Sass files/imports
cee-chen Jun 15, 2023
380190b
[EuiButtonEmpty] Convert tests from Enzyme to RTL
cee-chen Jun 15, 2023
9ba156a
[EuiButtonEmpty] Add Storybook
cee-chen Jun 15, 2023
b27f118
changelog
cee-chen Jun 21, 2023
03afc3f
Update downstream snapshots
cee-chen Jun 21, 2023
c49ba5b
Address specificity TODO
cee-chen Jun 23, 2023
02dae69
[PR feedback] comment typo
cee-chen Jun 26, 2023
0259dc8
Merge branch 'main' into emotion/button-empty
cee-chen Jun 26, 2023
921b1a7
snapshot
cee-chen Jun 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
78 changes: 38 additions & 40 deletions src/components/basic_table/__snapshots__/basic_table.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,22 +177,21 @@ exports[`EuiBasicTable renders (kitchen sink) with pagination, selection, sortin
class="euiPopover__anchor css-16vtueo-render"
>
<button
class="euiButtonEmpty euiButtonEmpty--xSmall euiButtonEmpty--flushRight css-9t7nyf-empty-primary"
class="euiButtonEmpty emotion-euiButtonDisplay-euiButtonEmpty-xs-empty-primary-flush-right"
type="button"
>
<span
class="euiButtonContent euiButtonContent--iconRight euiButtonEmpty__content"
class="euiButtonEmpty__content emotion-euiButtonDisplayContent"
>
<span
class="euiButtonContent__icon"
color="inherit"
data-euiicon-type="arrowDown"
/>
<span
class="euiButtonEmpty__text"
class="eui-textTruncate euiButtonEmpty__text"
>
Sorting
</span>
<span
color="inherit"
data-euiicon-type="arrowDown"
/>
</span>
</button>
</div>
Expand Down Expand Up @@ -419,14 +418,14 @@ exports[`EuiBasicTable renders (kitchen sink) with pagination, selection, sortin
class="euiToolTipAnchor emotion-euiToolTipAnchor-inlineBlock"
>
<button
class="euiButtonEmpty euiButtonEmpty--small euiButtonEmpty--flushRight euiTableCellContent__hoverItem css-9t7nyf-empty-primary"
class="euiButtonEmpty euiTableCellContent__hoverItem emotion-euiButtonDisplay-euiButtonEmpty-s-empty-primary-flush-right"
type="button"
>
<span
class="euiButtonContent euiButtonEmpty__content"
class="euiButtonEmpty__content emotion-euiButtonDisplayContent"
>
<span
class="euiButtonEmpty__text"
class="eui-textTruncate euiButtonEmpty__text"
>
Edit
</span>
Expand All @@ -437,14 +436,14 @@ exports[`EuiBasicTable renders (kitchen sink) with pagination, selection, sortin
class="euiToolTipAnchor emotion-euiToolTipAnchor-inlineBlock"
>
<button
class="euiButtonEmpty euiButtonEmpty--small euiButtonEmpty--flushRight euiTableCellContent__hoverItem css-9t7nyf-empty-primary"
class="euiButtonEmpty euiTableCellContent__hoverItem emotion-euiButtonDisplay-euiButtonEmpty-s-empty-primary-flush-right"
type="button"
>
<span
class="euiButtonContent euiButtonEmpty__content"
class="euiButtonEmpty__content emotion-euiButtonDisplayContent"
>
<span
class="euiButtonEmpty__text"
class="eui-textTruncate euiButtonEmpty__text"
>
Delete
</span>
Expand Down Expand Up @@ -540,14 +539,14 @@ exports[`EuiBasicTable renders (kitchen sink) with pagination, selection, sortin
class="euiToolTipAnchor emotion-euiToolTipAnchor-inlineBlock"
>
<button
class="euiButtonEmpty euiButtonEmpty--small euiButtonEmpty--flushRight euiTableCellContent__hoverItem css-9t7nyf-empty-primary"
class="euiButtonEmpty euiTableCellContent__hoverItem emotion-euiButtonDisplay-euiButtonEmpty-s-empty-primary-flush-right"
type="button"
>
<span
class="euiButtonContent euiButtonEmpty__content"
class="euiButtonEmpty__content emotion-euiButtonDisplayContent"
>
<span
class="euiButtonEmpty__text"
class="eui-textTruncate euiButtonEmpty__text"
>
Edit
</span>
Expand All @@ -558,14 +557,14 @@ exports[`EuiBasicTable renders (kitchen sink) with pagination, selection, sortin
class="euiToolTipAnchor emotion-euiToolTipAnchor-inlineBlock"
>
<button
class="euiButtonEmpty euiButtonEmpty--small euiButtonEmpty--flushRight euiTableCellContent__hoverItem css-9t7nyf-empty-primary"
class="euiButtonEmpty euiTableCellContent__hoverItem emotion-euiButtonDisplay-euiButtonEmpty-s-empty-primary-flush-right"
type="button"
>
<span
class="euiButtonContent euiButtonEmpty__content"
class="euiButtonEmpty__content emotion-euiButtonDisplayContent"
>
<span
class="euiButtonEmpty__text"
class="eui-textTruncate euiButtonEmpty__text"
>
Delete
</span>
Expand Down Expand Up @@ -661,14 +660,14 @@ exports[`EuiBasicTable renders (kitchen sink) with pagination, selection, sortin
class="euiToolTipAnchor emotion-euiToolTipAnchor-inlineBlock"
>
<button
class="euiButtonEmpty euiButtonEmpty--small euiButtonEmpty--flushRight euiTableCellContent__hoverItem css-9t7nyf-empty-primary"
class="euiButtonEmpty euiTableCellContent__hoverItem emotion-euiButtonDisplay-euiButtonEmpty-s-empty-primary-flush-right"
type="button"
>
<span
class="euiButtonContent euiButtonEmpty__content"
class="euiButtonEmpty__content emotion-euiButtonDisplayContent"
>
<span
class="euiButtonEmpty__text"
class="eui-textTruncate euiButtonEmpty__text"
>
Edit
</span>
Expand All @@ -679,14 +678,14 @@ exports[`EuiBasicTable renders (kitchen sink) with pagination, selection, sortin
class="euiToolTipAnchor emotion-euiToolTipAnchor-inlineBlock"
>
<button
class="euiButtonEmpty euiButtonEmpty--small euiButtonEmpty--flushRight euiTableCellContent__hoverItem css-9t7nyf-empty-primary"
class="euiButtonEmpty euiTableCellContent__hoverItem emotion-euiButtonDisplay-euiButtonEmpty-s-empty-primary-flush-right"
type="button"
>
<span
class="euiButtonContent euiButtonEmpty__content"
class="euiButtonEmpty__content emotion-euiButtonDisplayContent"
>
<span
class="euiButtonEmpty__text"
class="eui-textTruncate euiButtonEmpty__text"
>
Delete
</span>
Expand Down Expand Up @@ -780,25 +779,24 @@ exports[`EuiBasicTable renders (kitchen sink) with pagination, selection, sortin
class="euiPopover__anchor css-16vtueo-render"
>
<button
class="euiButtonEmpty euiButtonEmpty--xSmall css-wvaqcf-empty-text"
class="euiButtonEmpty emotion-euiButtonDisplay-euiButtonEmpty-xs-empty-text"
data-test-subj="tablePaginationPopoverButton"
type="button"
>
<span
class="euiButtonContent euiButtonContent--iconRight euiButtonEmpty__content"
class="euiButtonEmpty__content emotion-euiButtonDisplayContent"
>
<span
class="euiButtonContent__icon"
color="inherit"
data-euiicon-type="arrowDown"
/>
<span
class="euiButtonEmpty__text"
class="eui-textTruncate euiButtonEmpty__text"
>
Rows per page
:
3
</span>
<span
color="inherit"
data-euiicon-type="arrowDown"
/>
</span>
</button>
</div>
Expand Down Expand Up @@ -844,16 +842,16 @@ exports[`EuiBasicTable renders (kitchen sink) with pagination, selection, sortin
aria-controls="__table_generated-id"
aria-current="true"
aria-label="Page 1 of 2"
class="euiButtonEmpty euiButtonEmpty--small euiPaginationButton css-57pcyl-empty-disabled-euiPaginationButton-isActive"
class="euiButtonEmpty euiPaginationButton emotion-euiButtonDisplay-euiButtonEmpty-s-empty-disabled-isDisabled-euiPaginationButton-isActive"
data-test-subj="pagination-button-0"
disabled=""
type="button"
>
<span
class="euiButtonContent euiButtonEmpty__content"
class="euiButtonEmpty__content emotion-euiButtonDisplayContent"
>
<span
class="euiButtonEmpty__text"
class="eui-textTruncate euiButtonEmpty__text"
>
1
</span>
Expand All @@ -866,16 +864,16 @@ exports[`EuiBasicTable renders (kitchen sink) with pagination, selection, sortin
<a
aria-controls="__table_generated-id"
aria-label="Page 2 of 2"
class="euiButtonEmpty euiButtonEmpty--small euiPaginationButton css-2bs0sf-empty-text-euiPaginationButton"
class="euiButtonEmpty euiPaginationButton emotion-euiButtonDisplay-euiButtonEmpty-s-empty-text-euiPaginationButton"
data-test-subj="pagination-button-1"
href="#__table_generated-id"
rel="noreferrer"
>
<span
class="euiButtonContent euiButtonEmpty__content"
class="euiButtonEmpty__content emotion-euiButtonDisplayContent"
>
<span
class="euiButtonEmpty__text"
class="eui-textTruncate euiButtonEmpty__text"
>
2
</span>
Expand Down
42 changes: 20 additions & 22 deletions src/components/basic_table/__snapshots__/in_memory_table.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,23 +122,22 @@ exports[`EuiInMemoryTable behavior pagination 1`] = `
class="euiPopover__anchor css-16vtueo-render"
>
<button
class="euiButtonEmpty euiButtonEmpty--xSmall css-wvaqcf-empty-text"
class="euiButtonEmpty emotion-euiButtonDisplay-euiButtonEmpty-xs-empty-text"
data-test-subj="tablePaginationPopoverButton"
type="button"
>
<span
class="euiButtonContent euiButtonContent--iconRight euiButtonEmpty__content"
class="euiButtonEmpty__content emotion-euiButtonDisplayContent"
>
<span
class="euiButtonContent__icon"
color="inherit"
data-euiicon-type="arrowDown"
/>
<span
class="euiButtonEmpty__text"
class="eui-textTruncate euiButtonEmpty__text"
>
Rows per page: 2
</span>
<span
color="inherit"
data-euiicon-type="arrowDown"
/>
</span>
</button>
</div>
Expand Down Expand Up @@ -185,16 +184,16 @@ exports[`EuiInMemoryTable behavior pagination 1`] = `
<a
aria-controls="__table_generated-id"
aria-label="Page 1 of 2"
class="euiButtonEmpty euiButtonEmpty--small euiPaginationButton css-2bs0sf-empty-text-euiPaginationButton"
class="euiButtonEmpty euiPaginationButton emotion-euiButtonDisplay-euiButtonEmpty-s-empty-text-euiPaginationButton"
data-test-subj="pagination-button-0"
href="#__table_generated-id"
rel="noreferrer"
>
<span
class="euiButtonContent euiButtonEmpty__content"
class="euiButtonEmpty__content emotion-euiButtonDisplayContent"
>
<span
class="euiButtonEmpty__text"
class="eui-textTruncate euiButtonEmpty__text"
>
1
</span>
Expand All @@ -208,16 +207,16 @@ exports[`EuiInMemoryTable behavior pagination 1`] = `
aria-controls="__table_generated-id"
aria-current="true"
aria-label="Page 2 of 2"
class="euiButtonEmpty euiButtonEmpty--small euiPaginationButton css-57pcyl-empty-disabled-euiPaginationButton-isActive"
class="euiButtonEmpty euiPaginationButton emotion-euiButtonDisplay-euiButtonEmpty-s-empty-disabled-isDisabled-euiPaginationButton-isActive"
data-test-subj="pagination-button-1"
disabled=""
type="button"
>
<span
class="euiButtonContent euiButtonEmpty__content"
class="euiButtonEmpty__content emotion-euiButtonDisplayContent"
>
<span
class="euiButtonEmpty__text"
class="eui-textTruncate euiButtonEmpty__text"
>
2
</span>
Expand Down Expand Up @@ -775,23 +774,22 @@ exports[`EuiInMemoryTable with pagination and "show all" page size 1`] = `
class="euiPopover__anchor css-16vtueo-render"
>
<button
class="euiButtonEmpty euiButtonEmpty--xSmall css-wvaqcf-empty-text"
class="euiButtonEmpty emotion-euiButtonDisplay-euiButtonEmpty-xs-empty-text"
data-test-subj="tablePaginationPopoverButton"
type="button"
>
<span
class="euiButtonContent euiButtonContent--iconRight euiButtonEmpty__content"
class="euiButtonEmpty__content emotion-euiButtonDisplayContent"
>
<span
class="euiButtonContent__icon"
color="inherit"
data-euiicon-type="arrowDown"
/>
<span
class="euiButtonEmpty__text"
class="eui-textTruncate euiButtonEmpty__text"
>
Showing all rows
</span>
<span
color="inherit"
data-euiicon-type="arrowDown"
/>
</span>
</button>
</div>
Expand Down
85 changes: 0 additions & 85 deletions src/components/button/__snapshots__/button_content.test.tsx.snap
View file
Open in desktop

This file was deleted.

Loading