-
Notifications
You must be signed in to change notification settings - Fork 841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EuiAccordion] Split up rendering into sub-components & other cleanups #7161
Commits on Sep 6, 2023
-
[REFACTOR] Split up accordion trigger into button & arrow sub-components
- for easier dev readability and atomic styles + rename generic `iconButton` name to a more accurate `arrow` and remove className modifiers (use `[aria-expanded]` instead of `-isOpen` + inline some very minimal styles that don't require euiTheme or modifiers (trigger wrapper & optional action - action needs a label to trigger emotion snapshot serializer logic)
Configuration menu - View commit details
-
Copy full SHA for a73bede - Browse repository at this point
Copy the full SHA a73bedeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5ca4269 - Browse repository at this point
Copy the full SHA 5ca4269View commit details -
[misc cleanup] EuiAccordion - reorder imports & props
- order imports by specificity - order destrucuted props by approximate usage - remove unnecessary newlines
Configuration menu - View commit details
-
Copy full SHA for 255b5fb - Browse repository at this point
Copy the full SHA 255b5fbView commit details -
[REFACTOR] Split up accordion children into sub-components
- allows us to use more succinct useEffect/useRefs + remove extra unnecessary div wrapper (not really sure what it was even doing) + remove extra loading styles in favor of a quick inline one-liner
Configuration menu - View commit details
-
Copy full SHA for 84d8479 - Browse repository at this point
Copy the full SHA 84d8479View commit details -
[refactor] Switch to styles obj instead of modifying a DOM element di…
…rectly - this feels more react-y and has the benefit of not requiring an extra useEffect on mount
Configuration menu - View commit details
-
Copy full SHA for f7773f4 - Browse repository at this point
Copy the full SHA f7773f4View commit details -
[refactor] Remove manual tabbable controls and use
inert
attribute ……instead - see https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/inert - this property completely does what we want and full browser support was added in early 2023 - also allows us to remove `visibility` CSS which we were using to hide content from screen readers
Configuration menu - View commit details
-
Copy full SHA for 87f4faa - Browse repository at this point
Copy the full SHA 87f4faaView commit details -
[opinionated refactor] Clean up child wrapper styles
- remove CSS overrides in favor of two separate states - add missing motion media query around height/opacity transition - remove complete focus removal in favor of `:focus-visible` selector and existing mixin
Configuration menu - View commit details
-
Copy full SHA for 8567a31 - Browse repository at this point
Copy the full SHA 8567a31View commit details -
Configuration menu - View commit details
-
Copy full SHA for a72aa94 - Browse repository at this point
Copy the full SHA a72aa94View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3e82e7e - Browse repository at this point
Copy the full SHA 3e82e7eView commit details
Commits on Sep 7, 2023
-
Configuration menu - View commit details
-
Copy full SHA for e195f62 - Browse repository at this point
Copy the full SHA e195f62View commit details
Commits on Sep 8, 2023
-
[PR feedback] Reduce CSS overrides on arrow styles
- add `left` and `right` CSS keys - add open/closed CSS keys while we're here - update snapshots
Configuration menu - View commit details
-
Copy full SHA for dbcab02 - Browse repository at this point
Copy the full SHA dbcab02View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2d32730 - Browse repository at this point
Copy the full SHA 2d32730View commit details