Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiComboBox] Refactor singleSelection.asPlainText to make greater use of the underlying input element #7332

Merged
merged 12 commits into from
Nov 2, 2023
Merged

[EuiComboBox] Refactor singleSelection.asPlainText to make greater use of the underlying input element #7332

merged 12 commits into from
Nov 2, 2023

Commits on Nov 1, 2023

  1. [setup] Move pills map/rendering to its own class method 

    + add `asPlainText` as a getter, we'll be reusing this more shortly
    @cee-chen
    cee-chen committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    3903ff4 View commit details
    Browse the repository at this point in the history

  2. Update asPlainText display to show the selection in the input, inst… 

    …ead of as a separate DOM element

- this involves essentially disabling the autosize/width behavior of the input
    @cee-chen
    cee-chen committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    0a05f12 View commit details
    Browse the repository at this point in the history

  3. Remove plain text logic/styles from EuiComboBoxPill

    @cee-chen
    cee-chen committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    8509441 View commit details
    Browse the repository at this point in the history

  4. Allow backspaces to preserve the existing input text while still dele… 

    …ting the selection
    @cee-chen
    cee-chen committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    2feb532 View commit details
    Browse the repository at this point in the history

  5. Restore prepend/append plain text rendering + write DRY util

    @cee-chen
    cee-chen committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    f29f085 View commit details
    Browse the repository at this point in the history

  6. Update other EuiComboBox usages to dogfood new append/prepend util 

    + simplify tests in EuiComboBox to remove snapshots - should be sufficiently covered by util unit etsts
    @cee-chen
    cee-chen committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    64e91c3 View commit details
    Browse the repository at this point in the history

  7. Restore click to re-open after option selection on plain text input

    @cee-chen
    cee-chen committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    5f382d6 View commit details
    Browse the repository at this point in the history

  8. [cleanup] Move unnecessary/unused CSS to main file 

    - this isn't being used anymore since we removed the 3rd party autosize dependency, and most of the styles seem to live in the main combobox Sass file, so might as well consolidate
    @cee-chen
    cee-chen committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    16e6f76 View commit details
    Browse the repository at this point in the history

  9. [refactor] Remove need for placeholder text el by using the actual … 

    …`placeholder` attr on the input component
    @cee-chen
    cee-chen committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    b688e20 View commit details
    Browse the repository at this point in the history

  10. [misc] CSS fixes/cleanup 

    - Fix placeholder and plain text alignment to match EuiFieldText by adding a class and extra padding-left

- Remove unnecessary `hover` pseudo around cursor (by default they only show on hover) and fix pills to also use the correct cursor when disabled
    @cee-chen
    cee-chen committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    31654d1 View commit details
    Browse the repository at this point in the history

  11. changelog

    @cee-chen
    cee-chen committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    ff2c50d View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2023

  1. Update Sass fonts to match Emotion (which fixes CI font issue)

    @cee-chen
    cee-chen committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    1e45fbd View commit details
    Browse the repository at this point in the history