Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiDataGrid] Badges in grid toolbar #7369

Merged
merged 27 commits into from
Nov 21, 2023

Commits on Nov 14, 2023

  1. Show badges in grid toolbar

    jughosta committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    1cfe8c0 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2023

  1. Add tests

    jughosta committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    4423ca3 View commit details
    Browse the repository at this point in the history
  2. Merge remote-tracking branch 'upstream/main' into 7283-grid-toolbar-b…

    …adges
    
    # Conflicts:
    #	src/components/datagrid/__snapshots__/data_grid.test.tsx.snap
    #	src/components/datagrid/controls/__snapshots__/column_selector.test.tsx.snap
    #	src/components/datagrid/controls/__snapshots__/column_sorting.test.tsx.snap
    jughosta committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    c358a37 View commit details
    Browse the repository at this point in the history
  3. Update tests

    jughosta committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    30aa39c View commit details
    Browse the repository at this point in the history
  4. Add changelog

    jughosta committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    f643745 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    562a8ea View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    a6f0b7d View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    7e2fa6e View commit details
    Browse the repository at this point in the history
  8. Rename changelog to PR id

    jughosta committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    0d47cd7 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    8eb7277 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    21e2d8e View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2023

  1. Update src/components/datagrid/controls/data_grid_toolbar_control.tsx

    Co-authored-by: Cee Chen <549407+cee-chen@users.noreply.github.com>
    jughosta and cee-chen authored Nov 21, 2023
    Configuration menu
    Copy the full SHA
    bafd011 View commit details
    Browse the repository at this point in the history
  2. Update snapshots

    jughosta committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    eb63b18 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a987085 View commit details
    Browse the repository at this point in the history
  4. [EuiButtonEmpty] Allow disabling the text wrapper

    (setup for datagrid button cleanup)
    
    - `textProps &&` is required now for typing, to avoid `false` shenanigans
    cee-chen committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    bb8cca0 View commit details
    Browse the repository at this point in the history
  5. [EuiFilterButton] Clean up DOM/CSS by disabling text wrapper

    - misc/optional cleanup while we're here and thinking about badges in buttons
    
    + update downstream `EuiSearchBar` snapshots
    cee-chen committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    3408cfb View commit details
    Browse the repository at this point in the history
  6. Update datagrid button to use new textProps={false}

    - this allows us to remove the extra flex group/wrappers completely, as the text and badge node now sit as siblings and automatically inherit button content flex layout
    
    - also lets us correctly text truncate the text content, if needed
    cee-chen committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    5e3b8c9 View commit details
    Browse the repository at this point in the history
  7. [misc cleanup] Move new component props to file

    - TBH, the types are so simple I don't anticipate many consumers needing it, and I'd rather keep them where they're used. If consumers really do need it they can import directly from this file or use PropsOf
    
    - use `FC<>` typing to match rest of EUI
    cee-chen committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    472161e View commit details
    Browse the repository at this point in the history
  8. CSS fixes/className cleanups

    - add styles for underlining text, but not the badge
    
    - fix cursor on badge
    
    - add `className` hooks to both text & badge nodes in case consumers want to customize their CSS
    
    - misc/consistency - rename props (rest, classes, etc) to match other EUI components
    cee-chen committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    184f1b7 View commit details
    Browse the repository at this point in the history
  9. [cleanup] Remove .euiDataGrid__controlBtn className

    - in favor of `.euiDataGridToolbarControl` (now that we have a specific component for this)
    
    - remove the active `font-weight` as well, since it's no longer being used
    
    - remove `.euiDataGrid__controlBtn` from the icon buttons as well - they're not consistently applied and they're not really doing anything, nor are they being hooked into in Kibana for the icon buttons
    
    - replace fullscreen hook with `aria-pressed` instead
    
    + snapshot updates
    cee-chen committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    f467443 View commit details
    Browse the repository at this point in the history
  10. [cleanup] EuiDataGridToolbarControl tests

    - make unit tests more focused
    - add specific assertions in addition to snapshots
    - add test for new `textProps` behavior
    cee-chen committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    41aac63 View commit details
    Browse the repository at this point in the history
  11. [cleanup] Badge text assertions

    - make the text assertion more specific, now that we can look at the badge node
    cee-chen committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    4c3c8e5 View commit details
    Browse the repository at this point in the history
  12. [a11y] Screen reader UX improvements for columns badge

    + simplify logic of columns badge
    cee-chen committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    f4d0c88 View commit details
    Browse the repository at this point in the history
  13. changelog

    cee-chen committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    9a67614 View commit details
    Browse the repository at this point in the history
  14. Revert "[EuiFilterButton] Clean up DOM/CSS by disabling text wrapper"

    - This is too noisy for a datagrid-specific PR, I'll cherry-pick it out and open up a follow-up PR once this one merges
    
    This reverts commit 3408cfb.
    cee-chen committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    545e6de View commit details
    Browse the repository at this point in the history
  15. [docs] Add more documentation for new EuiDataGridToolbarControl

    - update copy + props tables
    cee-chen committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    44cb0f4 View commit details
    Browse the repository at this point in the history
  16. React 16/17 snapshots

    - gets me every time...
    cee-chen committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    43e5426 View commit details
    Browse the repository at this point in the history