-
Notifications
You must be signed in to change notification settings - Fork 841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EuiDataGrid] Badges in grid toolbar #7369
[EuiDataGrid] Badges in grid toolbar #7369
Commits on Nov 14, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 1cfe8c0 - Browse repository at this point
Copy the full SHA 1cfe8c0View commit details
Commits on Nov 15, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 4423ca3 - Browse repository at this point
Copy the full SHA 4423ca3View commit details -
Merge remote-tracking branch 'upstream/main' into 7283-grid-toolbar-b…
…adges # Conflicts: # src/components/datagrid/__snapshots__/data_grid.test.tsx.snap # src/components/datagrid/controls/__snapshots__/column_selector.test.tsx.snap # src/components/datagrid/controls/__snapshots__/column_sorting.test.tsx.snap
Configuration menu - View commit details
-
Copy full SHA for c358a37 - Browse repository at this point
Copy the full SHA c358a37View commit details -
Configuration menu - View commit details
-
Copy full SHA for 30aa39c - Browse repository at this point
Copy the full SHA 30aa39cView commit details -
Configuration menu - View commit details
-
Copy full SHA for f643745 - Browse repository at this point
Copy the full SHA f643745View commit details -
Configuration menu - View commit details
-
Copy full SHA for 562a8ea - Browse repository at this point
Copy the full SHA 562a8eaView commit details -
Configuration menu - View commit details
-
Copy full SHA for a6f0b7d - Browse repository at this point
Copy the full SHA a6f0b7dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7e2fa6e - Browse repository at this point
Copy the full SHA 7e2fa6eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0d47cd7 - Browse repository at this point
Copy the full SHA 0d47cd7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8eb7277 - Browse repository at this point
Copy the full SHA 8eb7277View commit details -
Configuration menu - View commit details
-
Copy full SHA for 21e2d8e - Browse repository at this point
Copy the full SHA 21e2d8eView commit details
Commits on Nov 21, 2023
-
Update src/components/datagrid/controls/data_grid_toolbar_control.tsx
Co-authored-by: Cee Chen <549407+cee-chen@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for bafd011 - Browse repository at this point
Copy the full SHA bafd011View commit details -
Configuration menu - View commit details
-
Copy full SHA for eb63b18 - Browse repository at this point
Copy the full SHA eb63b18View commit details -
Configuration menu - View commit details
-
Copy full SHA for a987085 - Browse repository at this point
Copy the full SHA a987085View commit details -
[EuiButtonEmpty] Allow disabling the text wrapper
(setup for datagrid button cleanup) - `textProps &&` is required now for typing, to avoid `false` shenanigans
Configuration menu - View commit details
-
Copy full SHA for bb8cca0 - Browse repository at this point
Copy the full SHA bb8cca0View commit details -
[EuiFilterButton] Clean up DOM/CSS by disabling text wrapper
- misc/optional cleanup while we're here and thinking about badges in buttons + update downstream `EuiSearchBar` snapshots
Configuration menu - View commit details
-
Copy full SHA for 3408cfb - Browse repository at this point
Copy the full SHA 3408cfbView commit details -
Update datagrid button to use new
textProps={false}
- this allows us to remove the extra flex group/wrappers completely, as the text and badge node now sit as siblings and automatically inherit button content flex layout - also lets us correctly text truncate the text content, if needed
Configuration menu - View commit details
-
Copy full SHA for 5e3b8c9 - Browse repository at this point
Copy the full SHA 5e3b8c9View commit details -
[misc cleanup] Move new component props to file
- TBH, the types are so simple I don't anticipate many consumers needing it, and I'd rather keep them where they're used. If consumers really do need it they can import directly from this file or use PropsOf - use `FC<>` typing to match rest of EUI
Configuration menu - View commit details
-
Copy full SHA for 472161e - Browse repository at this point
Copy the full SHA 472161eView commit details -
- add styles for underlining text, but not the badge - fix cursor on badge - add `className` hooks to both text & badge nodes in case consumers want to customize their CSS - misc/consistency - rename props (rest, classes, etc) to match other EUI components
Configuration menu - View commit details
-
Copy full SHA for 184f1b7 - Browse repository at this point
Copy the full SHA 184f1b7View commit details -
[cleanup] Remove
.euiDataGrid__controlBtn
className- in favor of `.euiDataGridToolbarControl` (now that we have a specific component for this) - remove the active `font-weight` as well, since it's no longer being used - remove `.euiDataGrid__controlBtn` from the icon buttons as well - they're not consistently applied and they're not really doing anything, nor are they being hooked into in Kibana for the icon buttons - replace fullscreen hook with `aria-pressed` instead + snapshot updates
Configuration menu - View commit details
-
Copy full SHA for f467443 - Browse repository at this point
Copy the full SHA f467443View commit details -
[cleanup] EuiDataGridToolbarControl tests
- make unit tests more focused - add specific assertions in addition to snapshots - add test for new `textProps` behavior
Configuration menu - View commit details
-
Copy full SHA for 41aac63 - Browse repository at this point
Copy the full SHA 41aac63View commit details -
[cleanup] Badge text assertions
- make the text assertion more specific, now that we can look at the badge node
Configuration menu - View commit details
-
Copy full SHA for 4c3c8e5 - Browse repository at this point
Copy the full SHA 4c3c8e5View commit details -
[a11y] Screen reader UX improvements for columns badge
+ simplify logic of columns badge
Configuration menu - View commit details
-
Copy full SHA for f4d0c88 - Browse repository at this point
Copy the full SHA f4d0c88View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9a67614 - Browse repository at this point
Copy the full SHA 9a67614View commit details -
Revert "[EuiFilterButton] Clean up DOM/CSS by disabling text wrapper"
- This is too noisy for a datagrid-specific PR, I'll cherry-pick it out and open up a follow-up PR once this one merges This reverts commit 3408cfb.
Configuration menu - View commit details
-
Copy full SHA for 545e6de - Browse repository at this point
Copy the full SHA 545e6deView commit details -
[docs] Add more documentation for new
EuiDataGridToolbarControl
- update copy + props tables
Configuration menu - View commit details
-
Copy full SHA for 44cb0f4 - Browse repository at this point
Copy the full SHA 44cb0f4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 43e5426 - Browse repository at this point
Copy the full SHA 43e5426View commit details