Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiRange][EuiDualRange] Respond to resizing/layout changes #7442

Merged
merged 6 commits into from
Jan 3, 2024

Commits on Jan 2, 2024

  1. [REVERT ME] issue repro

    cee-chen committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    7206b15 View commit details
    Browse the repository at this point in the history
  2. Add built in resize observer to internal range slider component

    + update parent range components to use the `onResize` callback instead of a ref callback
    cee-chen committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    700a618 View commit details
    Browse the repository at this point in the history
  3. [EuiDualRange] remove now-unnecessary resize/width logic

    - the internal resize observer handles all of it, no need for all this extra shenanigans
    
    - probably should've taken this approach in the first place
    
    - remove `onResize` class ref - should no longer be needed in Kibana
    cee-chen committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    8488c13 View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2024

  1. Add regression test for expected positioning

    - Honestly not sure how useful this is, but better to have something than nothing
    
    - we should eventually replace with with visual snapshot tests
    cee-chen committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    67360ae View commit details
    Browse the repository at this point in the history
  2. changelog

    cee-chen committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    ecb814a View commit details
    Browse the repository at this point in the history
  3. Revert "[REVERT ME] issue repro"

    This reverts commit 7206b15.
    cee-chen committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    4672131 View commit details
    Browse the repository at this point in the history