Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiFilterButton] DOM text wrapper cleanup #7444

Merged
merged 4 commits into from
Jan 5, 2024
Merged

[EuiFilterButton] DOM text wrapper cleanup #7444

merged 4 commits into from
Jan 5, 2024

Commits on Jan 3, 2024

  1. [EuiFilterButton] Clean up DOM/CSS by disabling text wrapper 

    - since EuiFilterButton already renders its own text wrapper, we're just removing an extra DOM node by removing the default EuiButtonEmpty one

+ using margin-right: auto to maintain the right-aligned arrow
    @cee-chen
    cee-chen committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    cb5c493 View commit details
    Browse the repository at this point in the history

  2. Update downstream snapshots

    @cee-chen
    cee-chen committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    9ed308d View commit details
    Browse the repository at this point in the history

  3. changelog 

    - mark as deprecation to match other EuiPopover DOM cleanup
    @cee-chen
    cee-chen committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    563252e View commit details
    Browse the repository at this point in the history

  4. Fix regression in min-width behavior 

    the min-width CSS was previously only applying for buttons with notifications, due to its `span` wrapper having `display: flex` set.

Now that the extra span wrapper is gone, text content is always rendered under `display: flex`, so we need to add a new CSS modifier to get it rendering the way it is in production
    @cee-chen
    cee-chen committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    9578d50 View commit details
    Browse the repository at this point in the history