Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent table row expansion to leak between table pages #761

Conversation

chandlerprall
Copy link
Contributor

Fixes #692 by creating a unique itemId for table items that incorporates their position in a paginated dataset.

Also fixes a bug where the expanded rows were not being associated with the owning aria row.

@chandlerprall chandlerprall requested review from cchaos and cjcenizal May 2, 2018 18:30
@chandlerprall
Copy link
Contributor Author

jenkins test this

Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chandlerprall
Copy link
Contributor Author

jenkins test this

1 similar comment
@chandlerprall
Copy link
Contributor Author

jenkins test this

@chandlerprall chandlerprall merged commit ef5fb86 into elastic:master May 3, 2018
@chandlerprall chandlerprall deleted the bug/692-row-expansion-on-pagination branch June 1, 2018 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Row expansion not working across table with multiple pages
2 participants