EuiComboBox - remove cross icon when singleSelection is enabled #769
Conversation
nreese
commented
May 3, 2018
nreese
commented
CHANGELOG.md
Outdated
| @@ -2,6 +2,7 @@ | |||
|
|
|||
| - Added `EuiDescribedFormGroup` component, a wrapper around `EuiFormRow`(s) ([#707](https://github.com/elastic/eui/pull/707)) | |||
| - Added `describedByIds` prop to `EuiFormRow` to help with accessibility ([#707](https://github.com/elastic/eui/pull/707)) | |||
| - `EuiComboBox` remove cross icon when `singleSelection` is enabled ([#769](https://github.com/elastic/eui/pull/769)) | |||
There was a problem hiding this comment.
Maybe...
Removed individual badge cross icon when
EuiComboBoxhassingleSelectionprop enabled.
When I read this at first I assumed you were removing the all clear cross.
There was a problem hiding this comment.
This is also adding the idea of single selection more than just the extra step of removing the badge's cross. May want say something regarding that?
| @@ -47,6 +47,7 @@ export class EuiComboBox extends Component { | |||
| options: [], | |||
| selectedOptions: [], | |||
| isClearable: true, | |||
| singleSelection: false, | |||
There was a problem hiding this comment.
This should be added to the propTypes object too, correct?
There was a problem hiding this comment.
it is already a prop type on EuiComboBox. This PR just sets a default value to false and passes the prop to EuiComboBoxInput.
There was a problem hiding this comment.
Ah you're right, we may want to think about alphabetizing our props... ha!
|
@cchaos There is already a docs section on single selection, https://github.com/elastic/eui/blob/master/src-docs/src/views/combo_box/combo_box_example.js#L197. Do you think this needs more details? |
