Bug/773 search bar boolean matching #776
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The search bar's grammar greedily prefers
boolean
fragments overword
fragments, but did not verify that the boolean text it matched again didn't exist within a larger word structure.e.g.
true
truest
off
andoffer
all match theboolean
type because they start with a valid boolean expression.This PR modifies the
containsValue
expression to look forboolean
followed by whitespace or End Of Input, otherwisecontainsValue
continues to match againstword
.true
,off
match asboolean
truest
,offer
match asword
Fixes #773