Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessibility/badge #777

Merged
merged 4 commits into from
May 4, 2018
Merged

Accessibility/badge #777

merged 4 commits into from
May 4, 2018

Conversation

snide
Copy link
Contributor

@snide snide commented May 4, 2018

Fixes #744

  • Adds a new prop_type for checking that an aria label exists when another prop (like onClick) also exists.
  • Applies this to EuiBadge for its various on clicks.
  • Properly label EuiComboBoxPill usage of EuiBadge

@snide snide requested a review from chandlerprall May 4, 2018 20:11
chandlerprall
chandlerprall approved these changes May 4, 2018
View reviewed changes
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@snide snide merged commit 7880eb1 into elastic:master May 4, 2018
@snide snide deleted the accessibility/badge branch May 4, 2018 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chandlerprall chandlerprall chandlerprall approved these changes

Assignees
No one assigned
Labels
accessibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@snide @chandlerprall