Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensuring switches’ inputs are still hidden when [disabled]. #778

Merged
merged 3 commits into from
May 7, 2018

Conversation

cchaos
Copy link
Contributor

@cchaos cchaos commented May 4, 2018

Fixes a bug where Kibana's input[type="checkbox"][disabled] { opacity: .8 } was overriding the opacity: 0 of the input for switches.

Before

screen shot 2018-05-04 at 16 20 51 pm

After

screen shot 2018-05-04 at 16 32 28 pm

cc @ppisljar

@cchaos cchaos added the bug label May 4, 2018
@cchaos cchaos requested review from chandlerprall and snide May 4, 2018 20:34
@cchaos cchaos changed the title Ensuring switches’ inputs it's still hidden when [disabled]. Ensuring switches’ inputs are still hidden when [disabled]. May 4, 2018
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cchaos cchaos merged commit e0110c3 into elastic:master May 7, 2018
@cchaos cchaos deleted the fix-disabled-switch branch May 7, 2018 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants