Workaround for :has CSS selector that nwsapi/jest can't parse
#7981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cee-chen
added
testing
cee-chen
force-pushed
the
rtl-selector-fix
branch
from
ebf8275
to
a3c4362
Compare
cee-chen
changed the title
:has CSS selector that nwsapi/jest can't parse
cee-chen
force-pushed
the
rtl-selector-fix
branch
from
a3c4362
to
b5b1579
Compare
💚 Build Succeeded
History
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is needed for Cloud's latest Kibana upgrade: https://github.com/elastic/cloud/pull/130938
The error output is something like
+labelisn't a valid selector. This test failure afects Cloud's RTL tests and does not affect browsers, only jsdom's test environment, due to nwsapi's spotty:has()selector support.This was reproducible in local EUI as well (first commit will fail tests without the second commit), and appears to primarily affect the
getByRoleAPI with thenameoption parameter (although in Cloud it affectsgetByLabelTextas well).This PR can and should be reverted when dperini/nwsapi#123 is fixed and a new version of nwsapi is available.
QA