Aria labeling for docs of plain form controls, aria-invalid attrib on EuiFormRow #799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snide
changed the title
snide
changed the title
aphelionz
approved these changes
May 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #782, #784
aria-invalidpassed toEuiFormRowitems if the input is invalid.I looked into using
aria-errormessageas @timroes suggested but found that the errors would not be read by screenreaders in chrome / safari. It seemed safer to leave them onaria-describedby, even if they mix in with help text. At least witharia-invalidthe messaging is more clear.