Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiBasicTable] Ensure action button aria-label is unique #7994

Merged

Conversation

mgadewoll
Copy link
Contributor

@mgadewoll mgadewoll commented Sep 3, 2024

Summary

closes #7883

This PR updates the aria-label on the CollapsedItemActions used in EuiBasicTable to add a reference to the current row to ensure the aria-label is unique and provides context.

Changes

  • passes current row index as new prop displayedRowIndex on CollapsedItemActions to use in the aria-label on the actions button
  • refactors usages of <EuiI18n> to use the useEuiI18n hook instead

Screenshots

Screenshot 2024-09-03 at 13 48 19

QA

  • review the DOM output in Storybook and verify action buttons have a reference to the current row, e.g. All actions, row 1

General checklist

  • Browser QA
    • Checked in both light and dark modes
    • Checked in mobile
    • Checked in Chrome, Safari, Edge, and Firefox
    • Checked for accessibility including keyboard-only and screenreader modes
  • Docs site QA
  • Code quality checklist
  • Release checklist
    • A changelog entry exists and is marked appropriately.
    • If applicable, added the breaking change issue label (and filled out the breaking change checklist)
  • Designer checklist
    • If applicable, file an issue to update EUI's Figma library with any corresponding UI changes. (This is an internal repo, if you are external to Elastic, ask a maintainer to submit this request)

Copy link

github-actions bot commented Sep 3, 2024

👋 Since this is a community submitted pull request, a Buildkite build has not been started automatically. Would an Elastic organization member please verify the contents of this pull request and kick off a build manually?

@mgadewoll mgadewoll marked this pull request as ready for review September 3, 2024 12:31
@mgadewoll mgadewoll requested a review from a team as a code owner September 3, 2024 12:31
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

Copy link
Member

@cee-chen cee-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@mgadewoll mgadewoll merged commit e36e441 into elastic:main Sep 6, 2024
5 checks passed
@mgadewoll mgadewoll deleted the table/7883-unique-action-button-a11y-label branch September 6, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[a11y] [EuiBasicTable] actions - overrides aria-label for multi-action button
4 participants