Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Emotion] Convert EuiDataGrid (Part 1) #7998

Merged
merged 9 commits into from
Sep 5, 2024
Merged

[Emotion] Convert EuiDataGrid (Part 1) #7998

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c0a75fb
Clean up and convert EuiDataGridPagination
cee-chen Aug 30, 2024
889ed4b
Convert fullscreen CSS to Emotion
cee-chen Aug 30, 2024
d91a75c
Add VRT screenshots of expected fullscreen styles
cee-chen Sep 4, 2024
70e283f
Convert scrollbar styles
cee-chen Aug 30, 2024
112ca79
Add storybook for scrollbar QA
cee-chen Sep 4, 2024
e0df28d
Convert datagrid wrapper styles
cee-chen Aug 30, 2024
00c91de
Convert grid body styles to Emotion
cee-chen Aug 30, 2024
187d90f
Delete Sass files
cee-chen Sep 4, 2024
48de274
changelog
cee-chen Sep 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added ...i/.loki/reference/chrome_desktop_Tabular_Content_EuiDataGrid_Virtualization.png
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Pinning this here with loose relation]

The scrollbar tests across browsers went as expected (showing custom scrollbars or default ones) except for Safari which always shows the same static/non-overlaying ones it seemed. But that is Safari 🤷‍♀️

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Safari: the new IE11!

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added ...ui/.loki/reference/chrome_mobile_Tabular_Content_EuiDataGrid_Virtualization.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
10 changes: 10 additions & 0 deletions packages/eui/src/components/datagrid/data_grid.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,7 @@ type Story = StoryObj<EuiDataGridProps>;

export const Playground: Story = {
args: {
'aria-label': 'EuiDataGrid',
columns,
rowCount: 10,
renderCellValue: RenderCellValue,
Expand Down Expand Up @@ -307,6 +308,15 @@ export const Playground: Story = {
};
enableFunctionToggleControls<EuiDataGridProps>(Playground, ['onColumnResize']);

export const Virtualization: Story = {
args: {
...Playground.args,
width: 300,
height: 300,
},
render: (args: EuiDataGridProps) => <StatefulDataGrid {...args} />,
};

export const HeightLineCount: Story = {
parameters: {
controls: {
Expand Down