Compressed forms #800
Closed
Compressed forms #800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
May 7, 2018 15:24
- `euiFormControlLayout`: for shifting the icons (and loading and clear) and reducing width - `field_search`, `field_text`, `field_number`, `field_password`, `select`, `checkbox`, `checkbox_group`, `radio`, `radio_group` - __NOT__ to `text_area`, `switch` - `file_picker` needed some extra work to make just look like a normal input field that is compressed. May want to consider also allowing for a non-compressed but but normal input style as well.
- Also fixes elastic#792: Moved bottom padding from help text to form row
|
I'll get this merged over your break. Loading it up locally it looks good though 👍 . I'll do a full-scan / review of the code of the code and tweak as needed. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
compressedprops toeuiFormControlLayout: for shifting the icons (and loading and clear) and reducing widthfield_search,field_text,field_number,field_password,select,checkbox,checkbox_group,radio,radio_group,text_area,switch(though it doesn't do anything for now)file_pickerneeded some extra work to make just look like a normal input field that is compressed. May want to consider also allowing for a non-compressed but but normal input style as well.euiFormRow: for reducing spacing between rows and passes down the variable to the child form controls