-
Notifications
You must be signed in to change notification settings - Fork 841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Emotion] Convert final EuiDataGrid cell styles (Part 5) #8013
Commits on Sep 10, 2024
-
Convert remaining
.euiDataGridRowCell
styles+ flatten specificity with `:where` selector
Configuration menu - View commit details
-
Copy full SHA for 175b2f8 - Browse repository at this point
Copy the full SHA 175b2f8View commit details -
Convert remaining
.euiDataGridRowCell__content
styles- JS logic lets us flatten and add more explanatory comments for the different height types
Configuration menu - View commit details
-
Copy full SHA for 046bfef - Browse repository at this point
Copy the full SHA 046bfefView commit details -
Configuration menu - View commit details
-
Copy full SHA for ba408b6 - Browse repository at this point
Copy the full SHA ba408b6View commit details
Commits on Sep 11, 2024
-
Convert remaining
.euiDataGridHeaderCell
styles- fairly straightforward - DRY out flex CSS between cell and focus trap div
Configuration menu - View commit details
-
Copy full SHA for 91a349c - Browse repository at this point
Copy the full SHA 91a349cView commit details -
[refactor] Remove unnecessary
CellContent
FC- just inline it, it's only used once
Configuration menu - View commit details
-
Copy full SHA for 89ad354 - Browse repository at this point
Copy the full SHA 89ad354View commit details -
Convert
.euiDataGridHeaderCell__content
styles- flatten left/right CSS since we have the prop right here + remove unnecessary flex-shrink CSS on the arrow - `EuiIcon` already takes care of that inherently
Configuration menu - View commit details
-
Copy full SHA for 45aeb31 - Browse repository at this point
Copy the full SHA 45aeb31View commit details -
[refactor] Clean up column actions button/icon DOM+CSS
- just reuse EuiButtonIcon with transform/animations unset and remove `__icon` - simplifies a ton of CSS - handle fontSize sizing of actions button in top level data grid styles - use `:not()` CSS to handle hidden state instead, which simplifies even more CSS
Configuration menu - View commit details
-
Copy full SHA for 95548bb - Browse repository at this point
Copy the full SHA 95548bbView commit details -
Convert
.euiDataGridHeaderCell__button
styles+ convert inline Emotion to styles & fix line-height shenanigans + move complex selectors to new util + wrap transition in animation media query
Configuration menu - View commit details
-
Copy full SHA for ccde288 - Browse repository at this point
Copy the full SHA ccde288View commit details -
Configuration menu - View commit details
-
Copy full SHA for c9327ca - Browse repository at this point
Copy the full SHA c9327caView commit details -
[refactor] clean up header control column DOM
- remove unnecessary `.euiDataGridHeaderCell__content` div element in control columns - it's not doing anything useful, so we might as well delete it + fix `focus_utils` rendering a `null` in control column `aria-describedby`
Configuration menu - View commit details
-
Copy full SHA for 8320712 - Browse repository at this point
Copy the full SHA 8320712View commit details -
Configuration menu - View commit details
-
Copy full SHA for 25d92ff - Browse repository at this point
Copy the full SHA 25d92ffView commit details -
[Enhancement] Replace unused header cell actions CSS
- font weight appears to be unused from an old theme - let's replace it with actual english text instead that indicates what clicking the button will do
Configuration menu - View commit details
-
Copy full SHA for 480f098 - Browse repository at this point
Copy the full SHA 480f098View commit details -
+ [enhancement] improve smoothness of dragging visibility with an `isDragging` modifier - clean up unnecessary inline style (only useful when dragging, we don't need it during, e.g. snapshots) + convert enzyme tests to RTL (requires using a ref for class methods instead of `.instance()`)
Configuration menu - View commit details
-
Copy full SHA for 22f27c8 - Browse repository at this point
Copy the full SHA 22f27c8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 18ce982 - Browse repository at this point
Copy the full SHA 18ce982View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2a80790 - Browse repository at this point
Copy the full SHA 2a80790View commit details -
Configuration menu - View commit details
-
Copy full SHA for 64d3ce5 - Browse repository at this point
Copy the full SHA 64d3ce5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9e68f6f - Browse repository at this point
Copy the full SHA 9e68f6fView commit details -
Configuration menu - View commit details
-
Copy full SHA for d70c124 - Browse repository at this point
Copy the full SHA d70c124View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5d47175 - Browse repository at this point
Copy the full SHA 5d47175View commit details -
Fix Storybook control docgen for
gridStyle
/rowHeightsOptions
/`too……lbarVisibility` stories - for some reason the ref was breaking the docgen?? - we didn't actually need the stateful grid for the ref tests, so just get rid of it
Configuration menu - View commit details
-
Copy full SHA for d7d70c2 - Browse repository at this point
Copy the full SHA d7d70c2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 456f5ef - Browse repository at this point
Copy the full SHA 456f5efView commit details -
Configuration menu - View commit details
-
Copy full SHA for 64f1748 - Browse repository at this point
Copy the full SHA 64f1748View commit details -
Configuration menu - View commit details
-
Copy full SHA for fb0178c - Browse repository at this point
Copy the full SHA fb0178cView commit details
Commits on Sep 12, 2024
-
[refactor] avoid render prop + unmemoized array by creating a new fun…
…ction component - not sure how much performance this is gaining us (if at all, it might be losing?) so IMO this is primarily a dev readability enhancement + make a few more props not overrideable via `setCellProps` (& update types) + write tests for merged `setCellProps` props
Configuration menu - View commit details
-
Copy full SHA for 3e6c32b - Browse repository at this point
Copy the full SHA 3e6c32bView commit details -
[a11y] Fix VO not correctly reading out SR text due to newlines in JSX
- otherwise, it continuously reads out "and 3 more items" instead of the full SR text :/
Configuration menu - View commit details
-
Copy full SHA for 7594ac8 - Browse repository at this point
Copy the full SHA 7594ac8View commit details -
[refactor] remove non-content children out of EuiDataGridCellContent
- neither the SR text or the cell actions are dependent on the renderCellValue content, and they don't need to be parsed by `HandleInteractiveChildren`, so move them out to the parent EuiDataGridCell + clean up now-unnecessary waterfalled props - move screen reader text out to its own function component to continue using useEuiI18n
Configuration menu - View commit details
-
Copy full SHA for bf7853e - Browse repository at this point
Copy the full SHA bf7853eView commit details -
[cleanup] Replace
hidden
attribute with conditional JSXcleaner snapshots, less DOM rendered, and and behaves the same way for screen readers, so why not
Configuration menu - View commit details
-
Copy full SHA for f53c710 - Browse repository at this point
Copy the full SHA f53c710View commit details -
[refactor] clean up focus trap aria-describedby text
- aria-describedby text doesn't need to be visible at all, we can just use `hidden`, which removes it from the copy clipboard + condense down to a single element
Configuration menu - View commit details
-
Copy full SHA for 0b29898 - Browse repository at this point
Copy the full SHA 0b29898View commit details