[EuiComboBox] Fix enter key not working correctly on selection clear/deletion buttons #8105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- move stateful component to a top level util - create a keyboard UX testing section, and move the backspace UX there
cee-chen
force-pushed
the
combobox/enter-key-fix
branch
from
026c4aa
to
39c5d64
Compare
|
Preview staging links for this PR:
|
💚 Build Succeeded
History
|
mgadewoll
approved these changes
Oct 30, 2024
|
Thanks Lene!! |
jbudz
pushed a commit
to elastic/kibana
that referenced
this pull request
Nov 12, 2024
`v97.3.0`⏩`v97.3.1` _[Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)_ --- ## [`v97.3.1`](https://github.com/elastic/eui/releases/v97.3.1) **Bug fixes** - Fixed an `EuiComboBox` bug where Enter keypresses were not working correctly on selection clear buttons ([#8105](elastic/eui#8105)) - Fixed an `EuiSuperDatePicker` bug where inputs would overflow out of smaller widths instead of truncating ([#8109](elastic/eui#8109)) - Fixed a bug with `EuiPageHeader`'s `rightSideItems` responsiveness where single items could overflow past the intended max width ([#8110](elastic/eui#8110))
tkajtoch
pushed a commit
to tkajtoch/kibana
that referenced
this pull request
Nov 12, 2024
`v97.3.0`⏩`v97.3.1` _[Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)_ --- ## [`v97.3.1`](https://github.com/elastic/eui/releases/v97.3.1) **Bug fixes** - Fixed an `EuiComboBox` bug where Enter keypresses were not working correctly on selection clear buttons ([elastic#8105](elastic/eui#8105)) - Fixed an `EuiSuperDatePicker` bug where inputs would overflow out of smaller widths instead of truncating ([elastic#8109](elastic/eui#8109)) - Fixed a bug with `EuiPageHeader`'s `rightSideItems` responsiveness where single items could overflow past the intended max width ([elastic#8110](elastic/eui#8110))
cee-chen
added a commit
to cee-chen/kibana
that referenced
this pull request
Nov 13, 2024
`v97.3.0`⏩`v97.3.1` _[Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)_ --- ## [`v97.3.1`](https://github.com/elastic/eui/releases/v97.3.1) **Bug fixes** - Fixed an `EuiComboBox` bug where Enter keypresses were not working correctly on selection clear buttons ([elastic#8105](elastic/eui#8105)) - Fixed an `EuiSuperDatePicker` bug where inputs would overflow out of smaller widths instead of truncating ([elastic#8109](elastic/eui#8109)) - Fixed a bug with `EuiPageHeader`'s `rightSideItems` responsiveness where single items could overflow past the intended max width ([elastic#8110](elastic/eui#8110)) (cherry picked from commit 4e65ae9) # Conflicts: # packages/kbn-securitysolution-exception-list-components/src/list_header/__snapshots__/list_header.test.tsx.snap
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Nov 18, 2024
`v97.3.0`⏩`v97.3.1` _[Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)_ --- ## [`v97.3.1`](https://github.com/elastic/eui/releases/v97.3.1) **Bug fixes** - Fixed an `EuiComboBox` bug where Enter keypresses were not working correctly on selection clear buttons ([elastic#8105](elastic/eui#8105)) - Fixed an `EuiSuperDatePicker` bug where inputs would overflow out of smaller widths instead of truncating ([elastic#8109](elastic/eui#8109)) - Fixed a bug with `EuiPageHeader`'s `rightSideItems` responsiveness where single items could overflow past the intended max width ([elastic#8110](elastic/eui#8110))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
closes #8104
closes #7289
QA
Item 1General checklist
- [ ] Checked in both light and dark modes- [ ] Checked in mobileand screenreader modesjest andcypress tests- [ ] Updated visual regression tests- [ ] If applicable, added the breaking change issue label (and filled out the breaking change checklist)