EuiComboBox - only call copyInputStyles when still mounted #813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjcenizal
approved these changes
May 10, 2018
chandlerprall
suggested changes
May 10, 2018
| @@ -454,7 +454,9 @@ export class EuiComboBox extends Component { | |||
|
|
|||
| // TODO: This will need to be called once the actual stylesheet loads. | |||
| setTimeout(() => { | |||
| this.autoSizeInput.copyInputStyles(); | |||
| if (this._isMounted) { | |||
There was a problem hiding this comment.
A better test is probably to see if this.autoSizeInput exists rather than if this component is mounted; more future proof (e.g. if the input element is sometimes not rendered based on another prop)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am occasionally getting an error when timeout function is getting called after component has unmounted.