Delete more unused Sass variables/mixins #8169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 0 usages in Kibana or Cloud
- 0 usages in Kibana
cee-chen
force-pushed
the
sass/more-deletions
branch
from
f43a774
to
fc5baff
Compare
|
Preview staging links for this PR:
|
💚 Build Succeeded
History
|
tkajtoch
reviewed
Nov 20, 2024
| /* Extend beta badges to at least 30% of the container's width or 112px (whichever is smaller) */ | ||
| ${logicalCSS('min-width', 'min(30%, 112px)')} | ||
| ${logicalCSS('min-width', `min(30%, ${euiTheme.base * 7}px)`)} |
tkajtoch
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I missed a couple low-hanging fruit Sass removals with 0 usages in #8031. All removals were checked in Kibana, Cloud, and Elastic Charts. As always, I recommend following along by commit.
QA
N/A
General checklist
- [ ] If applicable, added the breaking change issue label (and filled out the breaking change checklist)