Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiCollapsibleNavBeta] Consider adding aria-hidden="true" to the icon button for screen reader UX #7353 #8236

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Kukki8
Copy link

@Kukki8 Kukki8 commented Dec 13, 2024

Summary

This PR provides:

  • An added aria-hidden={buttonIsInteractive ? 'true' : 'false'} tag to the accordion_trigger.tsx file, as advised in the issue description.

This PR doesn't contain:

  • Changes in UI

closes #7353

Implementation

ChangeInEUIProject

QA

Remove or strikethrough items that do not apply to your PR.

General checklist

  • Browser QA
    • Checked in both light and dark modes
    • Checked in mobile
    • Checked in Chrome, Safari, Edge, and Firefox
    • Checked for accessibility including keyboard-only and screenreader modes
      • JAWS
      • NVDA
      • VoiceOver
  • Docs site QA
  • Code quality checklist
  • Release checklist
    • A changelog entry exists and is marked appropriately.
    • If applicable, added the breaking change issue label (and filled out the breaking change checklist)
  • Designer checklist
    • If applicable, file an issue to update EUI's Figma library with any corresponding UI changes. (This is an internal repo, if you are external to Elastic, ask a maintainer to submit this request)

@Kukki8 Kukki8 requested a review from a team as a code owner December 13, 2024 14:48
Copy link

cla-checker-service bot commented Dec 13, 2024

💚 CLA has been signed

Copy link

👋 Since this is a community submitted pull request, a Buildkite build has not been started automatically. Would an Elastic organization member please verify the contents of this pull request and kick off a build manually?

@weronikaolejniczak weronikaolejniczak self-assigned this Jan 16, 2025
@weronikaolejniczak
Copy link
Contributor

@Kukki8 thank you so much for your contribution! I'll review your PR soon 💚

@weronikaolejniczak
Copy link
Contributor

@Kukki8 hey, there! 👋🏻 Just wanted to check up on you, do you need any help making the suggested changes?

@Kukki8
Copy link
Author

Kukki8 commented Feb 2, 2025

@weronikaolejniczak Hello! I'm sorry for the delay, I've implemented the changes suggested 😄

@weronikaolejniczak
Copy link
Contributor

@Kukki8 no worries and thank you, all looks good now! 💚 Although the changes are exactly what the ticket says to do, I tested the component accessibility and I have some doubts, I'll get back to you in a day 😄

Copy link
Contributor

@weronikaolejniczak weronikaolejniczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have tested the changes (you can see the details here), everything looks great! Thank you so much for the amazing contribution 🥳 Feel free to take any other tasks if you want, we greatly appreciate any help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[EuiCollapsibleNavBeta] Consider adding aria-hidden="true" to the icon button for screen reader UX
2 participants