Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix combobox bugs introduced by isDisabled prop #838

Merged
merged 2 commits into from
May 17, 2018
Merged

fix combobox bugs introduced by isDisabled prop #838

merged 2 commits into from
May 17, 2018

Conversation

nreese
Copy link
Contributor

@nreese nreese commented May 16, 2018

PR #829 introduced 2 bugs into EuiComboBox

  1. Open the combo box displayed the console warning.

screen shot 2018-05-16 at 2 48 55 pm

  1. Setting isClearable to false on a combo box with selectedOptions still displayed the clear button

This PR fixes those bugs and adds some better snapshot testing.

@nreese nreese mentioned this pull request May 16, 2018
Merged
snide
snide approved these changes May 16, 2018
View reviewed changes
Copy link
Contributor

@snide snide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nreese. Sorry about that.

chandlerprall
chandlerprall approved these changes May 17, 2018
View reviewed changes
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Nathan!

@nreese nreese merged commit f7beb61 into elastic:master May 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snide snide snide approved these changes

@chandlerprall chandlerprall chandlerprall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nreese @chandlerprall @snide