Fix bug in which disabled link buttons don't look and act disabled #862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjcenizal
force-pushed
the
disabled-button-links
branch
from
075b166
to
19d5adc
Compare
cjcenizal
force-pushed
the
disabled-button-links
branch
from
19d5adc
to
d099bf3
Compare
…n didn't exhibit disabled behavior and visual state when href was defined.
cjcenizal
force-pushed
the
disabled-button-links
branch
from
d099bf3
to
33ec5ff
Compare
snide
approved these changes
May 22, 2018
chandlerprall
pushed a commit
to chandlerprall/eui
that referenced
this pull request
May 24, 2018
…n didn't exhibit disabled behavior and visual state when href was defined. (elastic#862)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
hrefwas defined on a button, then it would be rendered as an<a>, which doesn't recognize thedisabledattribute, and would therefore be unaffected by our styles which use this attribute in their selectors.I fixed this by rendering a
<button>element instead, whenisDisabled=true. This is a bit of a hack, but I think it's the cleanest solution, and I couldn't think of any side effects.