Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EuiIcon no longer takes focus in Edge and IE unless tabIndex is specified as a value other than "-1" #900

Merged
merged 2 commits into from
Jun 5, 2018
Merged

EuiIcon no longer takes focus in Edge and IE unless tabIndex is specified as a value other than "-1" #900

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ad6efc9
EuiIcon no longer takes focus in Edge and IE unless tabIndex='0' is s…
cjcenizal Jun 4, 2018
78a8af9
Address feedback.
cjcenizal Jun 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
**Bug fixes**
- Removed `.nvmrc` file from published npm package ([#892](https://github.com/elastic/eui/pull/892))
- `EuiComboBox` no longer shows the _clear_ icon when it's a no-op ([#890](https://github.com/elastic/eui/pull/890))
- `EuiIcon` no longer takes focus in Edge and IE unless `tabIndex='0'` is specified ([#900](https://github.com/elastic/eui/pull/900))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.. or is specified...


## [`0.0.51`](https://github.com/elastic/eui/tree/v0.0.51)

Expand Down
9 changes: 9 additions & 0 deletions src/components/accordion/__snapshots__/accordion.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ exports[`EuiAccordion behavior closes when clicked twice 1`] = `
>
<arrowRight
className="euiIcon euiIcon--medium"
focusable="false"
height="16"
style={
Object {
Expand All @@ -73,6 +74,7 @@ exports[`EuiAccordion behavior closes when clicked twice 1`] = `
>
<svg
className="euiIcon euiIcon--medium"
focusable="false"
height="16"
style={
Object {
Expand Down Expand Up @@ -190,6 +192,7 @@ exports[`EuiAccordion behavior opens when clicked once 1`] = `
>
<arrowDown
className="euiIcon euiIcon--medium"
focusable="false"
height="16"
style={
Object {
Expand All @@ -203,6 +206,7 @@ exports[`EuiAccordion behavior opens when clicked once 1`] = `
>
<svg
className="euiIcon euiIcon--medium"
focusable="false"
height="16"
style={
Object {
Expand Down Expand Up @@ -284,6 +288,7 @@ exports[`EuiAccordion is rendered 1`] = `
>
<svg
class="euiIcon euiIcon--medium"
focusable="false"
height="16"
viewBox="0 0 16 16"
width="16"
Expand Down Expand Up @@ -346,6 +351,7 @@ exports[`EuiAccordion props buttonContent is rendered 1`] = `
>
<svg
class="euiIcon euiIcon--medium"
focusable="false"
height="16"
viewBox="0 0 16 16"
width="16"
Expand Down Expand Up @@ -412,6 +418,7 @@ exports[`EuiAccordion props buttonContentClassName is rendered 1`] = `
>
<svg
class="euiIcon euiIcon--medium"
focusable="false"
height="16"
viewBox="0 0 16 16"
width="16"
Expand Down Expand Up @@ -474,6 +481,7 @@ exports[`EuiAccordion props extraAction is rendered 1`] = `
>
<svg
class="euiIcon euiIcon--medium"
focusable="false"
height="16"
viewBox="0 0 16 16"
width="16"
Expand Down Expand Up @@ -543,6 +551,7 @@ exports[`EuiAccordion props initialIsOpen is rendered 1`] = `
>
<svg
class="euiIcon euiIcon--medium"
focusable="false"
height="16"
viewBox="0 0 16 16"
width="16"
Expand Down
3 changes: 3 additions & 0 deletions src/components/badge/__snapshots__/badge.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,7 @@ exports[`EuiBadge props iconSide left is rendered 1`] = `
>
<svg
class="euiIcon euiIcon--small euiBadge__icon"
focusable="false"
height="18"
viewBox="0 0 18 18"
width="18"
Expand Down Expand Up @@ -173,6 +174,7 @@ exports[`EuiBadge props iconSide right is rendered 1`] = `
>
<svg
class="euiIcon euiIcon--small euiBadge__icon"
focusable="false"
height="18"
viewBox="0 0 18 18"
width="18"
Expand Down Expand Up @@ -207,6 +209,7 @@ exports[`EuiBadge props iconType is rendered 1`] = `
>
<svg
class="euiIcon euiIcon--small euiBadge__icon"
focusable="false"
height="18"
viewBox="0 0 18 18"
width="18"
Expand Down
3 changes: 3 additions & 0 deletions src/components/button/__snapshots__/button.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,7 @@ exports[`EuiButton props iconSide left is rendered 1`] = `
<svg
aria-hidden="true"
class="euiIcon euiIcon--medium euiButton__icon"
focusable="false"
height="18"
viewBox="0 0 18 18"
width="18"
Expand Down Expand Up @@ -188,6 +189,7 @@ exports[`EuiButton props iconSide right is rendered 1`] = `
<svg
aria-hidden="true"
class="euiIcon euiIcon--medium euiButton__icon"
focusable="false"
height="18"
viewBox="0 0 18 18"
width="18"
Expand Down Expand Up @@ -224,6 +226,7 @@ exports[`EuiButton props iconType is rendered 1`] = `
<svg
aria-hidden="true"
class="euiIcon euiIcon--medium euiButton__icon"
focusable="false"
height="18"
viewBox="0 0 18 18"
width="18"
Expand Down
3 changes: 3 additions & 0 deletions src/components/button/button_empty/__snapshots__/button_empty.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,7 @@ exports[`EuiButtonEmpty props iconSide left is rendered 1`] = `
<svg
aria-hidden="true"
class="euiIcon euiIcon--medium euiButtonEmpty__icon"
focusable="false"
height="18"
viewBox="0 0 18 18"
width="18"
Expand Down Expand Up @@ -168,6 +169,7 @@ exports[`EuiButtonEmpty props iconSide right is rendered 1`] = `
<svg
aria-hidden="true"
class="euiIcon euiIcon--medium euiButtonEmpty__icon"
focusable="false"
height="18"
viewBox="0 0 18 18"
width="18"
Expand Down Expand Up @@ -202,6 +204,7 @@ exports[`EuiButtonEmpty props iconType is rendered 1`] = `
<svg
aria-hidden="true"
class="euiIcon euiIcon--medium euiButtonEmpty__icon"
focusable="false"
height="18"
viewBox="0 0 18 18"
width="18"
Expand Down
1 change: 1 addition & 0 deletions src/components/button/button_icon/__snapshots__/button_icon.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ exports[`EuiButtonIcon props iconType is rendered 1`] = `
<svg
aria-hidden="true"
class="euiIcon euiIcon--medium euiButtonIcon__icon"
focusable="false"
height="18"
viewBox="0 0 18 18"
width="18"
Expand Down
1 change: 1 addition & 0 deletions src/components/call_out/__snapshots__/call_out.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@ exports[`EuiCallOut props iconType is rendered 1`] = `
<svg
aria-hidden="true"
class="euiIcon euiIcon--medium euiCallOutHeader__icon"
focusable="false"
height="18"
viewBox="0 0 18 18"
width="18"
Expand Down
1 change: 1 addition & 0 deletions src/components/card/__snapshots__/card.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ exports[`EuiCard icon 1`] = `
>
<svg
class="euiIcon euiIcon--medium myIconClass euiCard__icon"
focusable="false"
height="32"
viewBox="0 0 32 32"
width="32"
Expand Down
7 changes: 7 additions & 0 deletions src/components/context_menu/__snapshots__/context_menu.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ exports[`EuiContextMenu props panels and initialPanelId allows you to click the
>
<svg
class="euiIcon euiIcon--medium euiContextMenu__icon"
focusable="false"
height="16"
viewBox="0 0 16 16"
width="16"
Expand Down Expand Up @@ -80,6 +81,7 @@ exports[`EuiContextMenu props panels and initialPanelId allows you to click the
>
<svg
class="euiIcon euiIcon--medium euiContextMenu__icon"
focusable="false"
height="16"
viewBox="0 0 16 16"
width="16"
Expand Down Expand Up @@ -125,6 +127,7 @@ exports[`EuiContextMenu props panels and initialPanelId allows you to click the
>
<svg
class="euiIcon euiIcon--medium euiContextMenu__icon"
focusable="false"
height="16"
viewBox="0 0 16 16"
width="16"
Expand Down Expand Up @@ -165,6 +168,7 @@ exports[`EuiContextMenu props panels and initialPanelId allows you to click the
</span>
<svg
class="euiIcon euiIcon--medium euiContextMenu__arrow"
focusable="false"
height="16"
viewBox="0 0 16 16"
width="16"
Expand Down Expand Up @@ -199,6 +203,7 @@ exports[`EuiContextMenu props panels and initialPanelId allows you to click the
</span>
<svg
class="euiIcon euiIcon--medium euiContextMenu__arrow"
focusable="false"
height="16"
viewBox="0 0 16 16"
width="16"
Expand Down Expand Up @@ -233,6 +238,7 @@ exports[`EuiContextMenu props panels and initialPanelId allows you to click the
</span>
<svg
class="euiIcon euiIcon--medium euiContextMenu__arrow"
focusable="false"
height="16"
viewBox="0 0 16 16"
width="16"
Expand Down Expand Up @@ -276,6 +282,7 @@ exports[`EuiContextMenu props panels and initialPanelId renders the referenced p
>
<svg
class="euiIcon euiIcon--medium euiContextMenu__icon"
focusable="false"
height="16"
viewBox="0 0 16 16"
width="16"
Expand Down
1 change: 1 addition & 0 deletions src/components/context_menu/__snapshots__/context_menu_item.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ exports[`EuiContextMenuItem props hasPanel is rendered 1`] = `
/>
<svg
class="euiIcon euiIcon--medium euiContextMenu__arrow"
focusable="false"
height="16"
viewBox="0 0 16 16"
width="16"
Expand Down
1 change: 1 addition & 0 deletions src/components/context_menu/__snapshots__/context_menu_panel.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ exports[`EuiContextMenuPanel props onClose renders a button as a title 1`] = `
>
<svg
class="euiIcon euiIcon--medium euiContextMenu__icon"
focusable="false"
height="16"
viewBox="0 0 16 16"
width="16"
Expand Down
2 changes: 2 additions & 0 deletions src/components/empty_prompt/__snapshots__/empty_prompt.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ exports[`EuiEmptyPrompt is rendered 1`] = `
>
<svg
class="euiIcon euiIcon--xxLarge euiIcon--subdued"
focusable="false"
height="16"
viewBox="0 0 16 16"
width="16"
Expand Down Expand Up @@ -120,6 +121,7 @@ exports[`EuiEmptyPrompt props iconType renders alone 1`] = `
>
<svg
class="euiIcon euiIcon--xxLarge euiIcon--subdued"
focusable="false"
height="16"
viewBox="0 0 16 16"
width="16"
Expand Down
1 change: 1 addition & 0 deletions src/components/filter_group/__snapshots__/filter_select_item.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ exports[`EuiFilterSelectItem is rendered 1`] = `
>
<svg
class="euiIcon euiIcon--medium"
focusable="false"
height="16"
viewBox="0 0 16 16"
width="16"
Expand Down
1 change: 1 addition & 0 deletions src/components/form/file_picker/__snapshots__/file_picker.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ exports[`EuiFilePicker is rendered 1`] = `
<svg
aria-hidden="true"
class="euiIcon euiIcon--large euiFilePicker__icon"
focusable="false"
height="16"
viewBox="0 0 16 16"
width="16"
Expand Down
5 changes: 5 additions & 0 deletions src/components/form/form_control_layout/__snapshots__/form_control_layout.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ exports[`EuiFormControlLayout props clear onClick is rendered 1`] = `
>
<svg
class="euiIcon euiIcon--medium euiFormControlLayout__clearIcon"
focusable="false"
height="16"
viewBox="0 0 16 16"
width="16"
Expand Down Expand Up @@ -62,6 +63,7 @@ exports[`EuiFormControlLayout props icon is rendered as a string 1`] = `
<svg
aria-hidden="true"
class="euiIcon euiIcon--medium euiFormControlLayout__icon"
focusable="false"
height="16"
viewBox="0 0 16 16"
width="16"
Expand Down Expand Up @@ -93,6 +95,7 @@ exports[`EuiFormControlLayout props icon is rendered as an object 1`] = `
aria-hidden="true"
class="euiIcon euiIcon--medium euiFormControlLayout__icon customClass"
data-test-subj="myIcon"
focusable="false"
height="16"
viewBox="0 0 16 16"
width="16"
Expand Down Expand Up @@ -123,6 +126,7 @@ exports[`EuiFormControlLayout props icon side left is rendered 1`] = `
<svg
aria-hidden="true"
class="euiIcon euiIcon--medium euiFormControlLayout__icon"
focusable="false"
height="16"
viewBox="0 0 16 16"
width="16"
Expand Down Expand Up @@ -153,6 +157,7 @@ exports[`EuiFormControlLayout props icon side right is rendered 1`] = `
<svg
aria-hidden="true"
class="euiIcon euiIcon--medium euiFormControlLayout__icon"
focusable="false"
height="16"
viewBox="0 0 16 16"
width="16"
Expand Down
2 changes: 2 additions & 0 deletions src/components/form/switch/__snapshots__/switch.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ exports[`EuiSwitch is rendered 1`] = `
>
<svg
class="euiIcon euiIcon--medium euiSwitch__icon"
focusable="false"
height="16"
viewBox="0 0 16 16"
width="16"
Expand All @@ -40,6 +41,7 @@ exports[`EuiSwitch is rendered 1`] = `
</svg>
<svg
class="euiIcon euiIcon--medium euiSwitch__icon euiSwitch__icon--checked"
focusable="false"
height="16"
viewBox="0 0 16 16"
width="16"
Expand Down
3 changes: 3 additions & 0 deletions src/components/header/__snapshots__/header_logo.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ exports[`EuiHeaderLogo is rendered 1`] = `
>
<svg
class="euiIcon euiIcon--xLarge euiHeaderLogo__icon"
focusable="false"
height="32"
viewBox="0 0 32 32"
width="32"
Expand Down Expand Up @@ -53,6 +54,7 @@ exports[`EuiHeaderLogo renders href 1`] = `
>
<svg
class="euiIcon euiIcon--xLarge euiHeaderLogo__icon"
focusable="false"
height="32"
viewBox="0 0 32 32"
width="32"
Expand Down Expand Up @@ -98,6 +100,7 @@ exports[`EuiHeaderLogo renders optional props 1`] = `
>
<svg
class="euiIcon euiIcon--xLarge euiHeaderLogo__icon"
focusable="false"
height="16"
title="Moby Dick"
viewBox="0 0 16 16"
Expand Down
4 changes: 4 additions & 0 deletions src/components/header/header_alert/__snapshots__/header_alert.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ exports[`EuiHeaderAlert is rendered 1`] = `
<svg
aria-hidden="true"
class="euiIcon euiIcon--medium euiButtonIcon__icon"
focusable="false"
height="16"
viewBox="0 0 16 16"
width="16"
Expand Down Expand Up @@ -77,6 +78,7 @@ exports[`EuiHeaderAlert renders action 1`] = `
<svg
aria-hidden="true"
class="euiIcon euiIcon--medium euiButtonIcon__icon"
focusable="false"
height="16"
viewBox="0 0 16 16"
width="16"
Expand Down Expand Up @@ -144,6 +146,7 @@ exports[`EuiHeaderAlert renders date as an element 1`] = `
<svg
aria-hidden="true"
class="euiIcon euiIcon--medium euiButtonIcon__icon"
focusable="false"
height="16"
viewBox="0 0 16 16"
width="16"
Expand Down Expand Up @@ -209,6 +212,7 @@ exports[`EuiHeaderAlert renders title as an element 1`] = `
<svg
aria-hidden="true"
class="euiIcon euiIcon--medium euiButtonIcon__icon"
focusable="false"
height="16"
viewBox="0 0 16 16"
width="16"
Expand Down
1 change: 1 addition & 0 deletions src/components/header/header_links/__snapshots__/header_links.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ exports[`EuiHeaderLinks is rendered 1`] = `
>
<svg
class="euiIcon euiIcon--medium"
focusable="false"
height="16"
viewBox="0 0 16 16"
width="16"
Expand Down
Loading