Flyout alterations #925
Flyout alterations #925
Conversation
- Added “cross” close button to top right as default if (“onClose”) is present - Added option for a border below header - Altered doc examples to represent how we _want_ the flyouts to display consistently
There was a problem hiding this comment.
This looks great. Thanks for picking it up.
Don't forget the changelog before you merge. Because people were adding these on their own, and the default ability will add them (which makes sense) we should prolly add some sort of warning in the changelog more than usual. It's not a breaking change, but people should be aware to remove their additive stuff.
| /** | ||
| * Locks the mouse / keyboard focus to within the flyout | ||
| */ | ||
| ownFocus: PropTypes.bool, | ||
| }; | ||
|
|
||
| EuiFlyout.defaultProps = { |
There was a problem hiding this comment.
Can you set defaults for the false values here just so the docs read a little better.
- Added default bool props - changelog
|
cc @ycombinator, @justinkambic. I noticed you were adding these close buttons manually in the Pipeline viewer. We're just going to make it a default EUI behavior. When this merges down into Kibana, you'll want to remove your additional buttons so that we don't have duplicate functionality. |
|
@snide Thanks for the heads up. BTW, grepping through the Kibana code it looks like there are manually-added close buttons in quite a few other places too. I'm not sure how all those other places of |
|
The close buttons in the footer should be fine. Generally they shouldn't need them anymore, but they won't visually "break" things. |
@snide I made some design decisions on the header, let me know if you think otherwise.