Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing size of inputs via box-shadow #928

Merged
merged 2 commits into from
Jun 15, 2018

Conversation

cchaos
Copy link
Contributor

@cchaos cchaos commented Jun 14, 2018

The box-shadow that mimics the input’s border is now inset. This means the 40px height is actually 40px and the box-shadow ensure it's borders don't spill over the 400px width.

It's very subtle, hence the zoomed in gif. I also tweaked the second box-shadow slightly to have a better edge to it.

This also touched the EuiComboBoxList styles since it was doing extra css to account for the extended border.


This originally was noticed as an issue when I saw this:
https://github.com/elastic/kibana/blame/master/src/core_plugins/input_control_vis/public/components/editor/controls_tab.less

So cc'ing @nreese : This will fix the problem you were running into with inputs inside of accordions. When this get's merged into Kibana, can you remove this extra style? It will cause visual issues with the accordion if for some reason it doesn't correctly get the height of 0. See example:

image

The box-shadow that mimics the input’s border is now `inset`.
@nreese
Copy link
Contributor

nreese commented Jun 14, 2018

created elastic/kibana#19927 in the kibana repo to track the issue. Thanks for looping me in.

Copy link
Contributor

@snide snide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

@cchaos cchaos merged commit ffeea17 into elastic:master Jun 15, 2018
@cchaos cchaos deleted the form-control-shadow branch June 15, 2018 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants