Custom column sort values for EuiInMemoryTable #929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjcenizal
approved these changes
Jun 14, 2018
| SelectionType, | ||
| ItemIdType, | ||
| ItemIdType, FieldDataColumnTypeShape, ComputedColumnType, ActionsColumnType, |
There was a problem hiding this comment.
Maybe put each import on its own line for consistency?
chandlerprall
force-pushed
the
feature/425-custom-table-sort-logic
branch
from
7c553ba
to
9f1b758
Compare
4 tasks
30 tasks
This was referenced May 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #425. Allows the
sortablevalue onEuiInMemoryTable's columns to be a function which, when that column is sorted, is passed eachitemand the return value is used for sorting.