Refactor EuiTabbedContent to track its selected tab by name #931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @jgowdyelastic who brought this one up originally. |
cjcenizal
suggested changes
Jun 15, 2018
| @@ -76,7 +76,9 @@ export class EuiTabbedContent extends Component { | |||
| } = this.props; | |||
|
|
|||
| // Allow the consumer to control tab selection. | |||
| const selectedTab = externalSelectedTab || this.state.selectedTab | |||
| const selectedTab = externalSelectedTab || tabs.find( | |||
| tab => tab.name === this.state.selectedTabName | |||
There was a problem hiding this comment.
Realistically, it's very unlikely anyone would ever have multiple tabs with the same name - who does that! But it's theoretically possible, and there's nothing about a property called "name" which implies it should be unique. But this logic depends on it being unique to work correctly. If there are two tabs with the same name, clicking on the second tab will show you the first. How about using id to track the selected tab instead?
|
@cjcenizal great catch! I've updated to use |
chandlerprall
force-pushed
the
bug/930-tabbed-content-updates
branch
from
d6e2380
to
74a46ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #930
EuiTabbedContentpreviously stored the entire tab object in itsselectedTabstate, so any updates/changes to the passed-in tab content was ignored until the user switched away from and back to that same tab. This PR changes the component to track the selected tab by name so it will always pull content from the prop instead of caching it in state.