Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiCodeEditor] Provide selection target for functional tests #939

Merged
merged 2 commits into from
Jun 21, 2018
Merged

[EuiCodeEditor] Provide selection target for functional tests #939

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c8e4cb0
Providing selection target for functional tests
ycombinator Jun 21, 2018
49b22c2
Adding release note
ycombinator Jun 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

- Added `getPopoverScreenCoordinates` service function for positioining popover/tooltip content, updated `EuiToolTip` to use it ([#924](https://github.com/elastic/eui/pull/924))
- Allow `mode` prop in `EuiCodeEditor` to take custom mode object ([#935](https://github.com/elastic/eui/pull/935))
- `EuiCodeEditor` is now decorated with a `data-test-subj` selector (`codeEditorContainer`) ([#939](https://github.com/elastic/eui/pull/939))

## [`0.0.54`](https://github.com/elastic/eui/tree/v0.0.54)

Expand Down
2 changes: 2 additions & 0 deletions src/components/code_editor/__snapshots__/code_editor.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ exports[`EuiCodeEditor behavior hint element should be tabable 1`] = `
exports[`EuiCodeEditor is rendered 1`] = `
<div
class="euiCodeEditorWrapper"
data-test-subj="codeEditorContainer"
>
<div
class="euiCodeEditorKeyboardHint"
Expand Down Expand Up @@ -192,6 +193,7 @@ exports[`EuiCodeEditor is rendered 1`] = `
exports[`EuiCodeEditor props isReadOnly renders alternate hint text 1`] = `
<div
class="euiCodeEditorWrapper"
data-test-subj="codeEditorContainer"
>
<div
class="euiCodeEditorKeyboardHint"
Expand Down
1 change: 1 addition & 0 deletions src/components/code_editor/code_editor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,7 @@ export class EuiCodeEditor extends Component {
<div
className={classes}
style={{ width, height }}
data-test-subj="codeEditorContainer"
>
{prompt}

Expand Down