Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added word-break fallback for FF & IE in table cell #962

Merged
merged 3 commits into from
Jul 2, 2018
Merged

Added word-break fallback for FF & IE in table cell #962

merged 3 commits into from
Jul 2, 2018

Conversation

cchaos
Copy link
Contributor

@cchaos cchaos commented Jul 2, 2018 •
edited
Loading

Before

screen shot 2018-07-02 at 16 56 09 pm

After

screen shot 2018-07-02 at 16 56 24 pm

Addresses #855 (comment) and fixes #855 and fixes #943

cc @jen-huang

@cchaos cchaos added the bug label Jul 2, 2018
@cchaos cchaos requested a review from jen-huang July 2, 2018 20:58
@cchaos cchaos changed the title Added word-break fallback for FF & IE Added word-break fallback for FF & IE in table cell Jul 2, 2018
jen-huang
jen-huang approved these changes Jul 2, 2018
View reviewed changes
Copy link
Contributor

@jen-huang jen-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cchaos cchaos merged commit 6f457eb into elastic:master Jul 2, 2018
@cchaos cchaos deleted the text-wrap-table branch July 2, 2018 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jen-huang jen-huang jen-huang approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Text is not wrapping in inspector table on IE Firefox/IE doesn't support word-break: break-word;
2 participants
@cchaos @jen-huang