Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add inputRef prop to EuiFieldPassword #970

Merged
merged 2 commits into from
Jul 5, 2018
Merged

Add inputRef prop to EuiFieldPassword #970

merged 2 commits into from
Jul 5, 2018

Conversation

chandlerprall
Copy link
Contributor

Fixes #964 by adding the inputRef prop to EuiFieldPassword, making it match the other input components.

cchaos
cchaos approved these changes Jul 5, 2018
View reviewed changes
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this.!

@zinckiwi
Copy link
Contributor

zinckiwi commented Jul 5, 2018

Appreciated! LGTM

@chandlerprall chandlerprall merged commit 4a7c39e into elastic:master Jul 5, 2018
@chandlerprall chandlerprall deleted the bug/964-euifieldpassword-missing-ref branch July 5, 2018 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cchaos cchaos cchaos approved these changes

@zinckiwi zinckiwi Awaiting requested review from zinckiwi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chandlerprall @zinckiwi @cchaos