Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow size to be passed in for EuiIconTip #987

Merged
merged 2 commits into from
Jul 10, 2018
Merged

Allow size to be passed in for EuiIconTip #987

merged 2 commits into from
Jul 10, 2018

Conversation

walterra
Copy link
Contributor

@walterra walterra commented Jul 10, 2018 •
edited
Loading

Fixes #986.

Similar to what #580 does for the color attribute, size is now a prop for EuiIconTip to specify icon size.

cchaos
cchaos approved these changes Jul 10, 2018
View reviewed changes
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for adding!

@walterra walterra merged commit aeedb9b into elastic:master Jul 10, 2018
@walterra walterra deleted the icon-tooltip-size branch July 10, 2018 13:55
@walterra walterra mentioned this pull request Jul 11, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cchaos cchaos cchaos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@walterra @cchaos