Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add typings for keyCodes #988

Merged
merged 3 commits into from
Jul 10, 2018
Merged

Add typings for keyCodes #988

merged 3 commits into from
Jul 10, 2018

Conversation

stacey-gammon
Copy link
Contributor

Fixes #984

@stacey-gammon
Copy link
Contributor Author

This is how I tested. First see the typescript error:

screen shot 2018-07-10 at 2 55 58 pm

Then I added the typings to any declared eui module in node_modules (location shouldn't matter):
screen shot 2018-07-10 at 2 57 04 pm

Then... no more error:
screencapture

cjcenizal
cjcenizal approved these changes Jul 10, 2018
View reviewed changes
Copy link
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the instructions.

@stacey-gammon stacey-gammon merged commit a776a94 into elastic:master Jul 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjcenizal cjcenizal cjcenizal approved these changes

@chandlerprall chandlerprall Awaiting requested review from chandlerprall

Assignees
No one assigned
Labels
typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typescript: need typings for keyCodes
2 participants
@stacey-gammon @cjcenizal