Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

max_agents setting in fleet unclear #1595

Closed
pjbertels opened this issue Jun 23, 2022 · 6 comments
Closed

max_agents setting in fleet unclear #1595

pjbertels opened this issue Jun 23, 2022 · 6 comments
Assignees
Labels
bug Something isn't working Project:FleetScaling Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team

Comments

@pjbertels
Copy link

Kibana version:
8.3.0+

Elasticsearch version:

Server OS version:

Browser version:

Browser OS version:

Original install method (e.g. download page, yum, from source, etc.):

Describe the bug:
The Fleet integration has a field max_agents and some other advanced settings and they are documented here(https://www.elastic.co/guide/en/fleet/current/fleet-server-scalability.html#recommend-settings-scaling-agents). This setting(max_agents) may or may not affect a bunch of other advanced settings related to the scalability of the Fleet server. In ESS we have not been able to find the logs that Sean thought would give an indication to how these settings are set for a given cluster. It is possible in ESS that the decision was made not to change the settings at all in favor of other scaling strategies.
Changing the setting to 12,000 and doing a test with enrolling 10,000 Horde drones(enrolling at 20 drones /per sec ) does not seem to make a noticeable difference.

Steps to reproduce:
1.
2.
3.

Expected behavior:

Screenshots (if relevant):

Errors in browser console (if relevant):

Provide logs and/or server output (if relevant):

Any additional context:

@pjbertels pjbertels added bug Something isn't working Team:Fleet Label for the Fleet team Project:FleetScaling labels Jun 23, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@joshdover joshdover transferred this issue from elastic/kibana Jun 24, 2022
@joshdover
Copy link
Contributor

We need to provide some documentation on this setting, including what it sets, how the default is calculated (or not), etc. We should also consider automatically configuring this value in Cloud if possible (either auto-calculated at runtime or set via kibana.yml)

@nimarezainia nimarezainia added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Jun 24, 2022
@nimarezainia
Copy link

@joshdover I do have a draft to mend documentation. However last week we realized that these defaults may not be set correctly. i don't know how to confirm if these variables are set or set to the correct value.

@pierrehilbert We need someone to take this topic up urgently. My suggestion would be to have the yaml box show the configuration (it used to have that) when the max agents value is set. thanks.

@AndersonQ AndersonQ self-assigned this Jun 28, 2022
@pjbertels
Copy link
Author

pjbertels commented Jun 29, 2022

I noticed that the 8.3 documentation(current) and the master documentation don't refer to max_agents but refer to max_connections in step 3.
https://www.elastic.co/guide/en/fleet/current/fleet-server-scalability.html
https://www.elastic.co/guide/en/fleet/master/fleet-server-scalability.html
but in the 8.3.0-SNAPSHOTS we have an indication to effect that max_connections is being deprecated.
image

And the plot thickens ...

@jen-huang jen-huang removed the Team:Fleet Label for the Fleet team label Jun 29, 2022
@joshdover
Copy link
Contributor

joshdover commented Jun 29, 2022

Some action items we identified in our sync today:

  • Need to clarify when the “max agent” field is not set, what is the behavior.
  • Add documentation about this behavior
  • Add a link to the “max agent” section in the integration to our documentation to explain how this works.
  • Add a log to Fleet Server that would dump all the information that is related to the server.runtime configuration. Log all of fleet server configuration at startup #1626

@joshdover
Copy link
Contributor

Close in favor of #1860

@joshdover joshdover closed this as not planned Won't fix, can't repro, duplicate, stale Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Project:FleetScaling Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Development

No branches or pull requests

6 participants