Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log all of fleet server configuration at startup #1626

Closed
ph opened this issue Jun 30, 2022 · 6 comments · Fixed by #1671
Closed

Log all of fleet server configuration at startup #1626

ph opened this issue Jun 30, 2022 · 6 comments · Fixed by #1671
Assignees
Labels
Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team v8.5.0

Comments

@ph
Copy link
Contributor

ph commented Jun 30, 2022

When debugging an issue in cloud it is useful to know with what options the fleet-server is operating at, because some options are derived from the current container size and other can be change with the fleet-server integration.

I would be good to log a single even that we can search through the log that would container the information defined in https://github.com/elastic/fleet-server/blob/3c8cd17c1370abb07f6935021d31c8204e4d16a3/internal/pkg/config/input.go

@ph
Copy link
Contributor Author

ph commented Jun 30, 2022

@michalpristas @joshdover as discussed.

@joshdover
Copy link
Contributor

These logs need to be sure to sanitize the configuration to avoid logging any sensitive fields like certificate private keys

@michel-laterman
Copy link
Contributor

It looks like there is some existing redacting/logging of fleet-server's config (from #692 and #620). I can use the same functions in order to ensure that config is also displayed on load.

@jlind23
Copy link
Contributor

jlind23 commented Jul 18, 2022

@michel-laterman did we make any progress on this one?

@michel-laterman
Copy link
Contributor

I have a PR that needs testing, i'll push it as a draft

@jlind23
Copy link
Contributor

jlind23 commented Jul 19, 2022

@michel-laterman thanks, would you mind linking it to this issue to keep track of it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team v8.5.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants