Consume APMConfig from input units in agent mode #3277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consume and prefer APMConfig from the expected input component while operating in agent mode over config in inputs[0].server.instrumentation.
michel-laterman
added
enhancement
changelog/fragments/1707852625-Prefer-elastic-agent-client-APMConfig-in-agent-mode.yaml
Outdated
Show resolved
Hide resolved
…Config-in-agent-mode.yaml
|
91.4% Coverage on New Code
0.0% Duplication on New Code
jlind23
added a commit
that referenced
this pull request
Feb 21, 2024
…SNAPSHOT (#3285) * Consume APMConfig from input units in agent mode (#3277) * Consume APMConfig from input units in agent mode Consume and prefer APMConfig from the expected input component while operating in agent mode over config in inputs[0].server.instrumentation. --------- Co-authored-by: Julia Bardi <90178898+juliaElastic@users.noreply.github.com> * [Release] update version (#3280) Co-authored-by: Julien Lind <julien.lind@elastic.co> * chore: Update snapshot.yml Made with ❤️️ by updatecli --------- Co-authored-by: Michel Laterman <82832767+michel-laterman@users.noreply.github.com> Co-authored-by: Julia Bardi <90178898+juliaElastic@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Julien Lind <julien.lind@elastic.co> Co-authored-by: apmmachine <apmmachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem this PR solves?
elastic-agent-client is now able to send APMConfig settings separately from expected config (similar to how the log level can be separated), but fleet-server is unable to use these settings.
How does this PR solve the problem?
Consume and prefer APMConfig from the expected input component while operating in agent mode over config in inputs[0].server.instrumentation.
Design Checklist
I have or intend to scale test my changes, ensuring it will work reliably with 100K+ agents connected.I have included fail safe mechanisms to limit the load on fleet-server: rate limiting, circuit breakers, caching, load shedding, etc.Checklist
I have made corresponding changes to the documentationI have made corresponding change to the default configuration files./changelog/fragmentsusing the changelog toolRelated issues