Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CP-7781 - switching bk pipeline to gpctl promote after synthetics #3916

Merged
merged 2 commits into from
Oct 1, 2024
Merged

CP-7781 - switching bk pipeline to gpctl promote after synthetics #3916

merged 2 commits into from
Oct 1, 2024

Conversation

mduarte
Copy link
Contributor

@mduarte mduarte commented Sep 19, 2024

Replacing pipeline gpctl-promote-with-e2e-tests with gpctl-promote-after-serverless-devenv-synthetics.
This will replace the execution of the E2E tests on promotion to dev/qa with the execution of the synthetics tests.

@mduarte mduarte requested a review from a team as a code owner September 19, 2024 12:02
@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 19, 2024

This pull request does not have a backport label. Could you fix it @mduarte? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-./d./d is the label to automatically backport to the 8./d branch. /d is the digit

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 19, 2024

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Sep 19, 2024
@mduarte mduarte force-pushed the CP-7781/gpctl-promote-synthetics branch from ac31066 to 5598c39 Compare September 19, 2024 12:17
@mduarte mduarte force-pushed the CP-7781/gpctl-promote-synthetics branch from 5598c39 to 3c5b473 Compare September 19, 2024 15:33
@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@mduarte
Copy link
Contributor Author

mduarte commented Sep 25, 2024

@platform-ingest Can someone please review this PR? 🙇

@pierrehilbert pierrehilbert added the Team:Elastic-Agent Label for the Agent team label Sep 25, 2024
michel-laterman
michel-laterman approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@michel-laterman michel-laterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mduarte mduarte merged commit eb9080e into main Oct 1, 2024
8 checks passed
@mduarte mduarte deleted the CP-7781/gpctl-promote-synthetics branch October 1, 2024 16:18
mergify bot pushed a commit that referenced this pull request Oct 1, 2024
@mduarte @mergify
CP-7781 - switching bk pipeline to gpctl promote after synthetics (#3916
bcca574 
)

(cherry picked from commit eb9080e)
@mergify mergify bot mentioned this pull request Oct 1, 2024
Merged
ycombinator pushed a commit that referenced this pull request Oct 2, 2024
@mergify @mduarte
CP-7781 - switching bk pipeline to gpctl promote after synthetics (#3916
6219cf5 
) (#3969)

(cherry picked from commit eb9080e)

Co-authored-by: Mario Duarte <mduarte@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michel-laterman michel-laterman michel-laterman approved these changes

@blakerouse blakerouse Awaiting requested review from blakerouse blakerouse is a code owner automatically assigned from elastic/elastic-agent-control-plane

@andrzej-stencel andrzej-stencel Awaiting requested review from andrzej-stencel andrzej-stencel is a code owner automatically assigned from elastic/elastic-agent-control-plane

Assignees
No one assigned
Labels
backport-8.x Automated backport to the 8.x branch with mergify Team:Elastic-Agent Label for the Agent team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mduarte @michel-laterman @pierrehilbert